Repository navigation
Conversation
Buzka91
commented
Oct 1, 2026
- call curl_close() only on PHP < 8.0 (no-op since 8.0, deprecated since 8.5)
- do not pass false to curl_error() when curl_init() fails, which threw TypeError instead of NetworkException on PHP 8
- call curl_close() only on PHP < 8.0 (no-op since 8.0, deprecated since 8.5) - do not pass false to curl_error() when curl_init() fails, which threw TypeError instead of NetworkException on PHP 8
Author
|
Hi @maciejlew, Could you take a look at this PR when you have a moment? It's a small, backward-compatible fix:
Since the library already declares PHP 8.5 support, every request made through the bundled cURL client currently triggers a deprecation notice on 8.5. We're running PHP 8.5 in production and use this as a workaround on our side for now. A patch release (e.g. 4.0.1) with this fix would let us drop the workaround. Thanks for maintaining the library! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.