Skip to content

fix: reject non-HTTP URL schemes in http_check.py (fixes #316) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 1 commit into from
Closed

fix: reject non-HTTP URL schemes in http_check.py (fixes #316) #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions python/http_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,15 @@ def main():
print(f"[!] Invalid URL structure: '{url_to_test}'", file=sys.stderr)
sys.exit(1)

# Validate URL scheme - only allow http and https
final_parsed = urllib.parse.urlparse(url_to_test)
if final_parsed.scheme and final_parsed.scheme.lower() not in ("http", "https"):
print(
f"[!] Error: Only http:// and https:// URLs are supported. Got scheme '{final_parsed.scheme}': '{url_to_test}'",
file=sys.stderr,
)
sys.exit(1)

check_url_features(url_to_test)


Expand Down