Skip to content

fix: reject non-HTTP URL schemes in http_check.py (fixes #316) - #338

Closed
KooshaPari wants to merge 1 commit into
simonw:mainfrom
KooshaPari:fix-316-file-scheme
Closed

fix: reject non-HTTP URL schemes in http_check.py (fixes #316)#338
KooshaPari wants to merge 1 commit into
simonw:mainfrom
KooshaPari:fix-316-file-scheme

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Sep 13, 2026

Copy link
Copy Markdown

Fixes #316

Changes

  • Added URL scheme validation after URL parsing
  • Rejects file://, ftp://, and other non-HTTP schemes with a clear error message
  • Only allows http:// and https:// schemes
  • Prevents local file access via file://localhost/... URLs

Copilot AI lite review requested due to automatic review settings September 13, 2026 05:48
Copilot AI reviewed Sep 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@KooshaPari KooshaPari closed this by deleting the head repository Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http_check.py allows opening local files via file://localhost/... URLs

2 participants

@KooshaPari