Repository navigation
fix(ocdav): [OCISDEV-1691] return 425 from COPY while the source is in postprocessing - #808
Merged
Merged
Conversation
LukasHirt
force-pushed
the
fix/OCISDEV-1691-copy-too-early
branch
from
November 11, 2026 20:23
fa9371d to
8a47f50
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…n postprocessing The internal download of a COPY source that is still in postprocessing returns 425 Too Early. COPY turned that into a 500 and then also tried to write the success status. Return 425 instead so clients can retry, and stop writing a second status after an error. Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt
force-pushed
the
fix/OCISDEV-1691-copy-too-early
branch
from
November 11, 2026 20:24
8a47f50 to
7730ce7
Compare
Signed-off-by: Lukas Hirt <info@hirt.cz>
mzner
approved these changes
Nov 16, 2026
deyankiteworks
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While a file is still in postprocessing (async uploads), the internal download that a WebDAV
COPYuses to read the source returns425 Too Early.handlePathCopyandhandleSpacesCopyturned every error into500 Internal Server Errorand then also wrote the success status (http: superfluous response.WriteHeader).This PR:
425 Too EarlyfromCOPYwhen the source download returns 425.GETandHEADalready return 425 for files in processing, so clients can now treatCOPYthe same way and retry.Related issue
apiSpacesShares/copySpaces.feature:268/269in fix: [OCISDEV-1593] roll back the Keycloak guest when the invitation mail fails ocis#13408How has this been tested?
ocdav_blackbox_test.goforCOPYon/dav/spaces: success (201), source in postprocessing (425), and source download failing (500).