Skip to content

fix: [OCISDEV-1691] wait for postprocessing in upload setup steps - #13435

Open
LukasHirt wants to merge 3 commits into
masterfrom
fix/OCISDEV-1691-wait-for-postprocessing
Open

LukasHirt wants to merge 3 commits into
masterfrom
fix/OCISDEV-1691-wait-for-postprocessing

Conversation

@LukasHirt

@LukasHirt LukasHirt commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

Acceptance tests that use a file right after a setup upload are flaky with async uploads, because the upload returns before postprocessing has finished. Seen in #13408:

  • apiSpacesShares/copySpaces.feature:268/269: the COPY returned 500. The internal download of the source returned 425 Too Early, and ocdav turned that into a 500.
  • apiActivities/activities.feature:1908: fewer activities than expected. The upload activity is only recorded after UploadReady, which is sent once postprocessing finishes.

This PR:

  • bumps reva to the fix(ocdav): [OCISDEV-1691] return 425 from COPY while the source is in postprocessing reva#808 merge commit, so COPY returns 425 Too Early while the source is still in postprocessing.
  • removes the retry-on-500 workaround from the COPY test step ([tests-only][full-ci] test: retry copy operation on 500 status code #12973). HttpRequestHelper already retries on 425.
  • makes the has uploaded file … / has uploaded a file inside space … setup steps send a HEAD after the upload. HEAD returns 425 while the file is in postprocessing, and the request helper retries until it doesn't, so the following steps start from a stable state.
  • skips that wait when a scenario changed the postprocessing config (any POSTPROCESSING_* setting, e.g. apiAsyncUpload/delayPostprocessing.feature, cliCommands/uploadSessions.feature), because those scenarios need the file to stay in postprocessing.

The reva bump also brings in the reva main commits merged since the last bump (owncloud/reva#775, owncloud/reva#801, owncloud/reva#787, owncloud/reva#811, owncloud/reva#807, owncloud/reva#817). Because of owncloud/reva#817, Go's minimum version selection also raises a few transitive deps (nats-server, x/crypto, x/sys, …).

Related issue

How has this been tested?

  • reva: new unit tests for COPY (201 / 425 / 500).
  • ocis: go build ./..., PHP syntax check of the changed test files. The acceptance tests in CI cover the rest.

@LukasHirt
LukasHirt requested a review from a team as a code owner November 11, 2026 20:30
@LukasHirt LukasHirt self-assigned this Nov 11, 2026
@update-docs

update-docs Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt
LukasHirt force-pushed the fix/OCISDEV-1691-wait-for-postprocessing branch from 0e524e4 to fac1fdf Compare November 11, 2026 20:30
@kw-security

kw-security commented Nov 11, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@LukasHirt
LukasHirt marked this pull request as draft November 11, 2026 20:36
@2403905

2403905 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Should the MOVE also return 425?

@LukasHirt

LukasHirt commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

@2403905 MOVE already does that. Only COPY does not.

@LukasHirt
LukasHirt force-pushed the fix/OCISDEV-1691-wait-for-postprocessing branch from fac1fdf to a9174fc Compare November 16, 2026 14:42
@LukasHirt
LukasHirt marked this pull request as ready for review November 16, 2026 14:43
@LukasHirt
LukasHirt force-pushed the fix/OCISDEV-1691-wait-for-postprocessing branch from a9174fc to 3305642 Compare November 16, 2026 14:52
deyankiteworks
deyankiteworks previously approved these changes Nov 16, 2026
Bump reva to get COPY returning 425 Too Early instead of 500 while the
source is still in postprocessing, and drop the retry-on-500 workaround
from the COPY test step. The request helper already retries on 425.

Make the "has uploaded" setup steps wait until the uploaded file has left
postprocessing, so that the following steps (copy, activities, ...) don't
race against it. Scenarios that change the postprocessing config keep the
file in postprocessing and skip the wait.

Signed-off-by: Lukas Hirt <info@hirt.cz>
@LukasHirt
LukasHirt force-pushed the fix/OCISDEV-1691-wait-for-postprocessing branch from 1ac99fb to 6657973 Compare November 18, 2026 07:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants