Repository navigation
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
LukasHirt
force-pushed
the
fix/OCISDEV-1691-wait-for-postprocessing
branch
from
November 11, 2026 20:30
0e524e4 to
fac1fdf
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LukasHirt
marked this pull request as draft
November 11, 2026 20:36
Contributor
|
Should the MOVE also return 425? |
Contributor
Author
|
@2403905 MOVE already does that. Only COPY does not. |
LukasHirt
force-pushed
the
fix/OCISDEV-1691-wait-for-postprocessing
branch
from
November 16, 2026 14:42
fac1fdf to
a9174fc
Compare
LukasHirt
marked this pull request as ready for review
November 16, 2026 14:43
LukasHirt
force-pushed
the
fix/OCISDEV-1691-wait-for-postprocessing
branch
from
November 16, 2026 14:52
a9174fc to
3305642
Compare
deyankiteworks
previously approved these changes
Nov 16, 2026
Bump reva to get COPY returning 425 Too Early instead of 500 while the source is still in postprocessing, and drop the retry-on-500 workaround from the COPY test step. The request helper already retries on 425. Make the "has uploaded" setup steps wait until the uploaded file has left postprocessing, so that the following steps (copy, activities, ...) don't race against it. Scenarios that change the postprocessing config keep the file in postprocessing and skip the wait. Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt
force-pushed
the
fix/OCISDEV-1691-wait-for-postprocessing
branch
from
November 18, 2026 07:24
1ac99fb to
6657973
Compare
PrajwolAmatya
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Acceptance tests that use a file right after a setup upload are flaky with async uploads, because the upload returns before postprocessing has finished. Seen in #13408:
apiSpacesShares/copySpaces.feature:268/269: the COPY returned 500. The internal download of the source returned 425 Too Early, and ocdav turned that into a 500.apiActivities/activities.feature:1908: fewer activities than expected. The upload activity is only recorded afterUploadReady, which is sent once postprocessing finishes.This PR:
HttpRequestHelperalready retries on 425.has uploaded file …/has uploaded a file inside space …setup steps send a HEAD after the upload. HEAD returns 425 while the file is in postprocessing, and the request helper retries until it doesn't, so the following steps start from a stable state.POSTPROCESSING_*setting, e.g.apiAsyncUpload/delayPostprocessing.feature,cliCommands/uploadSessions.feature), because those scenarios need the file to stay in postprocessing.The reva bump also brings in the reva
maincommits merged since the last bump (owncloud/reva#775, owncloud/reva#801, owncloud/reva#787, owncloud/reva#811, owncloud/reva#807, owncloud/reva#817). Because of owncloud/reva#817, Go's minimum version selection also raises a few transitive deps (nats-server, x/crypto, x/sys, …).Related issue
How has this been tested?
go build ./..., PHP syntax check of the changed test files. The acceptance tests in CI cover the rest.