Repository navigation
Conversation
….36. openresty/lua-nginx-module#2536 changes the FFI signature of ngx_http_lua_ffi_balancer_enable_keepalive(). Requiring the matching ngx_lua version fails early instead of calling it with the wrong arguments.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
ngx_http_lua_module0.10.33 (ngx_lua_version10033) and bumps lua-resty-core to 0.1.36.Why
openresty/lua-nginx-module#2536 changes the FFI signature of
ngx_http_lua_ffi_balancer_enable_keepalive()(newpool_sizeargument), and #544 calls it with the new signature. Requiring the matching ngx_lua version makes a mismatched pair fail whenresty.coreloads, instead of passing the wrong arguments to C.The stream requirement (
ngx_stream_lua_module0.0.20) is unchanged, since the change is http only.Paired PR
This must be merged together with openresty/lua-nginx-module#2540, which bumps
ngx_http_lua_versionto 10033. Merged alone, either side fails to loadresty.core.Related feature PRs: openresty/lua-nginx-module#2536 (C side), #544 (Lua side).
Temporary CI commit
CI clones lua-nginx-module master, which is still 10032. The last commit (
tests: TEMPORARY: ...) points CI at the branch of openresty/lua-nginx-module#2540. Drop it before merging.Testing (local, nginx 1.31.8)
t/balancer*.t,t/count.t,t/var.t,t/request.t,t/shdict.tall pass