Repository navigation
Conversation
The FFI signature of ngx_http_lua_ffi_balancer_enable_keepalive() changes in openresty#2536 (pool_size). Bumping the version lets lua-resty-core require the matching ngx_lua instead of calling the FFI function with the wrong arguments.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
ngx_http_lua_versionfrom 10032 to 10033 (0.10.33).Why
#2536 changes the FFI signature of
ngx_http_lua_ffi_balancer_enable_keepalive()(newpool_sizeargument). lua-resty-core checksngx.config.ngx_lua_versionexactly. Bumping the version lets an updated lua-resty-core refuse an older ngx_lua, and the other way round, instead of calling the FFI function with mismatched arguments.Paired PR
This must be merged together with openresty/lua-resty-core#547, which requires 10033 (and bumps lua-resty-core to 0.1.36). Merged alone, either side fails to load
resty.core.Related feature PRs: #2536 (C side), openresty/lua-resty-core#544 (Lua side).
Temporary CI commit
CI clones lua-resty-core master, which still requires 10032 and would fail to load. The last commit (
tests: TEMPORARY: ...) points CI at the branch of openresty/lua-resty-core#547. Drop it before merging.Testing (local, nginx 1.31.8)
t/balancer*.t,t/count.t,t/var.t,t/request.t,t/shdict.t, and lua-nginx-modulet/000-sanity.t,t/001-set.t,t/138-balancer.t,t/188-balancer_keepalive_pool_max_retry.tall pass