Skip to content

fix: correctly detect negative zero when serializing floats to JS #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhinav kumar (abhiraz7) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correctly detect negative zero when serializing floats to JS #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright/_impl/_js_handle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def serialize_value(
return dict(v="Infinity")
if value == float("-inf"):
return dict(v="-Infinity")
if value == float("-0"):
if value == 0 and math.copysign(1.0, value) == -1.0:
return dict(v="-0")
if math.isnan(value):
return dict(v="NaN")
Expand Down
5 changes: 5 additions & 0 deletions tests/async/test_page_evaluate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ async def test_evaluate_transfer_neg_zero(page: Page) -> None:
assert result == float("-0")


async def test_evaluate_transfer_positive_zero_stays_positive(page: Page) -> None:
result = await page.evaluate("a => Object.is(a, -0)", 0.0)
assert result is False


async def test_evaluate_transfer_infinity(page: Page) -> None:
result = await page.evaluate("a => a", float("Infinity"))
assert result == float("Infinity")
Expand Down