fix: correctly detect negative zero when serializing floats to JS - #3217
Open
Abhinav kumar (abhiraz7) wants to merge 1 commit into
Open
Abhinav kumar (abhiraz7) wants to merge 1 commit into
Abhinav kumar (abhiraz7) wants to merge 1 commit into
Conversation
0.0 == float('-0') is True in Python (float equality doesn'tdistinguish signed zero), so every 0.0 passed to evaluate() wasbeing tagged as -0 in the JS handshake. Use math.copysign to testthe actual sign bit instead.Fixes microsoft#3186
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3186.
value == float("-0")is always true for any 0.0 in Pythonsince float
equality doesn't distinguish signed zero — > so every plain 0.0 passed to
evaluate() was incorrectly serialized to JS -0. This uses math.copysign
to check the actual sign instead, and adds a regression test mirroring
the issue's repro (Object.is(a, -0)).