Skip to content

fix(intune): name the Trellix connector in MT.1098 - #2753

Merged
merill merged 1 commit into
maester365:mainfrom
julien-ly:fix/mt1098-trellix-id
Nov 9, 2026
Merged

merill merged 1 commit into
maester365:mainfrom
julien-ly:fix/mt1098-trellix-id

Conversation

@julien-ly

@julien-ly julien-ly commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

📑 Description

MT.1098 maps Mobile Threat Defense connector IDs to partner names. The Trellix Mobile Security entry was 4873197-ffec-4dfc-9816-db65f34c7cb9, with seven hex characters in its first block, so it never matched and a Trellix connector was shown by its raw ID. Microsoft365DSC carries the same value.

To get the real IDs, I created the Trellix Mobile Security and Windows Security Center connectors in the Intune admin center, with no platform toggle, and read them back from beta/deviceManagement/mobileThreatDefenseConnectors:

  • Trellix Mobile Security: 74873197-ffec-4dfc-9816-db65f34c7cb9
  • Windows Security Center: c2b688fe-48c0-464b-a89c-67041aa8fcb2, the value already in the table (Microsoft365DSC has e6f777f8-e4c2-4a5b-be01-50b5c124bc7f)

Both came back as notSetUp with a 0001-01-01 heartbeat.

This change restores the missing leading 7. It follows up on my comment on the ID table in #2736.

Tests

  • powershell/tests/functions/Test-MtMobileThreatDefenseConnectors.Tests.ps1: new case, a connector with the Trellix ID is named "Trellix Mobile Security" in the report and its ID isn't shown.
  • Locally, PowerShell 7: the MT.1098 tests, the general tests FileEncoding, PSScriptAnalyzer, Help, RepositoryLayout, NativeTest*, MaesterTestTags and LegacyIds, and ./build/Build-MaesterModule.ps1 pass. With main's Test.MT.1098.ps1, the new case fails.

✅ Checks

  • My pull request adheres to the code style of this project.
  • My code requires changes to the documentation.
  • I have updated the documentation as required.
  • The build and unit tests pass after running /powershell/tests/pester.ps1 locally.

ℹ️ Additional Information

Bug fix: only the connector name in the report changes; the verdict logic is untouched.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the Trellix Mobile Security connector identification so the expected connector is recognized and displayed by name.
    • Added a verification that the connector’s displayed result uses its name rather than exposing its identifier.

The ID table had 4873197-ffec-4dfc-9816-db65f34c7cb9, with seven hex characters in its first block, so a Trellix connector was shown by its raw ID. A Trellix Mobile Security connector created in the Intune admin center gets 74873197-ffec-4dfc-9816-db65f34c7cb9.
@julien-ly
julien-ly requested review from a team as code owners November 9, 2026 20:27
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The MT.1098 Trellix Mobile Security connector mapping now uses the corrected ID. A test verifies that the connector check passes, reports the connector by name, and omits the ID from the report.

Changes: Trellix connector identification

Layer / File(s) Summary
Correct Trellix connector identification
tests/maester/intune/Test.MT.1098.ps1, powershell/tests/functions/Test-MtMobileThreatDefenseConnectors.Tests.ps1
The MT.1098 mapping uses the corrected Trellix Mobile Security connector ID. A test verifies the check passes, the report names the connector, and the ID is not included.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: bug, product: intune, new test

Suggested reviewers: merill

Merge Risk: Minimal · up to eef6d

The change corrects the reported Trellix connector name. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly and concisely identifies the MT.1098 Trellix connector naming fix.
Description check Passed The description explains the incorrect ID, the correction, the report behavior, and the tests performed. It includes the required Description, Checks, and Additional Information sections. The full tes…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the incorrect ID, the correction, the report behavior, and the tests performed. It includes the required Description, Checks, and Additional Information sections. The full test-suite checkbox remains unchecked, but the description states which tests passed and notes that the full suite was not confirmed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d6c644b and eef6d8d.

Files selected for processing: 2

  • powershell/tests/functions/Test-MtMobileThreatDefenseConnectors.Tests.ps1
  • tests/maester/intune/Test.MT.1098.ps1

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@merill merill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks a lot @julien-ly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants