Skip to content

fix(intune): correct the Trellix connector ID in MT.1098 - #2754

Closed
merill wants to merge 1 commit into
mainfrom
fix/mt1098-trellix-id
Closed

merill wants to merge 1 commit into
mainfrom
fix/mt1098-trellix-id

Conversation

@merill

@merill merill commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

MT.1098 names each Mobile Threat Defense connector from a table of partner IDs. The Trellix Mobile Security entry was 4873197-ffec-4dfc-9816-db65f34c7cb9, seven characters in its first block, so it could never match and a Trellix connector was shown by its raw ID. julien-ly spotted this on #2736. Pass/fail was not affected.

  • Trellix is now 74873197-ffec-4dfc-9816-db65f34c7cb9, read from deviceManagement/mobileThreatDefenseConnectors after creating the connector in a tenant (Microsoft365DSC has the same typo).
  • Windows Security Center stays c2b688fe-48c0-464b-a89c-67041aa8fcb2, the ID Graph returned in a tenant in 🪲 MT.1098 does not consider policies that is ready for deployment but is first enabled after first registration #2595. Microsoft365DSC's e6f777f8-e4c2-4a5b-be01-50b5c124bc7f has not been seen from a tenant.
  • The source comment now points at the MSFT_IntuneMobileThreatDefenseConnector resource instead of a Windows 10 device configuration resource, and notes where the table differs from it.
  • A unit test checks that the Trellix and Windows Security Center IDs are reported by name.

Validation

  • ./powershell/tests/pester.ps1: 8430 tests, no failures.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the Trellix Mobile Security connector ID so it maps to the expected name in results.
    • Confirmed that Trellix Mobile Security and Windows Security Center connector IDs appear under their corresponding names in report tables.

The Trellix Mobile Security entry was missing the leading 7 of its
ID, so a Trellix connector was shown by its raw ID. The correct ID,
74873197-ffec-4dfc-9816-db65f34c7cb9, was read from Graph after
creating the connector in a tenant. Also point the source comment at
the right Microsoft365DSC resource and note where the table differs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Entire-Checkpoint: 01M710786Z860FPYCCHA5A1TKY
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The MT.1098 connector mapping now uses the corrected Trellix Mobile Security ID. Parameterized tests check that Trellix and Windows Security Center connector IDs appear as names in the report table.

Changes: Connector Mapping

Layer / File(s) Summary
Correct connector mapping and test display names
tests/maester/intune/Test.MT.1098.ps1, powershell/tests/functions/Test-MtMobileThreatDefenseConnectors.Tests.ps1
The Trellix Mobile Security mapping uses the corrected ID. Comments describe the connector ID and display-name mapping. Parameterized tests check that Trellix and Windows Security Center IDs appear as names in the report table.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: f-bader

Merge Risk: Minimal · up to 78355

The change corrects the Trellix connector name in reports. No merge-blocking issue was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the Trellix connector ID correction in MT.1098, which is the main change.
Description check Passed The description explains the problem, the corrected ID, the related Windows Security Center mapping, the source-comment update, and the unit test. It also reports the test results. It does not use the…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the corrected ID, the related Windows Security Center mapping, the source-comment update, and the unit test. It also reports the test results. It does not use the template’s Checks and Additional Information headings or include its checklist, but the description is otherwise complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d6c644b and 783550d.

Files selected for processing: 2

  • powershell/tests/functions/Test-MtMobileThreatDefenseConnectors.Tests.ps1
  • tests/maester/intune/Test.MT.1098.ps1

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant