Skip to content

test(todo): follow the claim-operation-id commands widened by #7510 #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LIHUA919 wants to merge 1 commit into from
+10 −2
Closed

test(todo): follow the claim-operation-id commands widened by #7510 #7569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/test_cli_argument_diagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,16 +559,24 @@ def test_todo_claim_validation_preserves_exact_diagnostics(
assert str(exc_info.value) == expected


@pytest.mark.parametrize("command", ["add", "list", "update", "complete", "supersede"])
@pytest.mark.parametrize("command", ["add", "list", "supersede"])
@pytest.mark.parametrize("operation_id", ["retry-one", ""])
def test_claim_operation_id_is_not_silently_ignored_by_other_commands(command, operation_id):
args = build_parser().parse_args([
"todo", command, "--goal-id", "example-goal", "--claim-operation-id", operation_id,
])
with pytest.raises(ValueError, match="supported only by todo claim"):
with pytest.raises(ValueError, match="supported only by todo claim/update/complete"):
validate_shared_todo_options(args)


@pytest.mark.parametrize("command", ["claim", "update", "complete"])
def test_claim_operation_id_is_shared_by_lease_bound_commands(command):
args = build_parser().parse_args([
"todo", command, "--goal-id", "example-goal", "--claim-operation-id", "retry-one",
])
validate_shared_todo_options(args)


@pytest.mark.parametrize(
("extra_args", "expected"),
[
Expand Down
Loading