Skip to content

test(todo): follow the claim-operation-id commands widened by #7510 - #7569

Closed
LIHUA919 wants to merge 1 commit into
loopx-project:mainfrom
LIHUA919:codex/claim-operation-id-test-20261028
Closed

LIHUA919 wants to merge 1 commit into
loopx-project:mainfrom
LIHUA919:codex/claim-operation-id-test-20261028

Conversation

@LIHUA919

Copy link
Copy Markdown
Contributor

Goal And Delivered Outcome

  • Outcome basis / optional anchor: Python Tests test-shard jobs on main. Each one fails at tests/test_cli_argument_diagnostics.py::test_claim_operation_id_is_not_silently_ignored_by_other_commands with DID NOT RAISE ValueError. This happened on the scheduled run at 9558f75ae (shards 1 and 2) and the push run at 5a65338fa (shard 4). Each shard hits whichever update/complete parametrizations it was assigned.
  • Goal/source and gap: fix(tasks): manage execution leases through ordinary task operations #7510 intentionally widened validate_shared_todo_options, so todo update and todo complete now accept --claim-operation-id (to settle a managed execution lease). The message became "supported only by todo claim/update/complete". The test still lists update and complete as commands that must reject the option.
  • Fix: the rejection test covers add, list and supersede and matches the current message. A new test asserts that claim, update and complete accept the option. No product code changed.
  • Observable before → after: the update/complete parametrizations stop failing main, and the widened behavior from fix(tasks): manage execution leases through ordinary task operations #7510 is now covered by a test.
  • Issue/task and intended base: follows fix(tasks): manage execution leases through ordinary task operations #7510. Base main.

Author Declaration

  • Written by: model_agent (Claude Opus, Anthropic), at the account owner's direction.

Implemented against

Criterion (spec clause) Disposition Symbol / path Test or command
Commands outside claim/update/complete still reject the option preserved test_claim_operation_id_is_not_silently_ignored_by_other_commands pytest tests/test_cli_argument_diagnostics.py
claim/update/complete accept the option implemented test_claim_operation_id_is_shared_by_lease_bound_commands same
  • Self-check before submission: negative control. I put the validator back to claim-only, and the new test then fails for update and complete.

Scope And Continuation

  • Completed scope: test only.
  • Not covered: two other one-off main failures, tests/test_native_steward_reports.py::test_original_pump_resumes_exact_prelaunch_rejection_once_without_replaying_unknown_work[False-file] (IndexError, one shard) and tests/test_lark_private_conversations.py::test_app_long_return_keeps_all_parts_and_does_not_repeat_identical_parts (one shard). Each failed only once, so this PR leaves them alone.

Validation

  • Tested revision: d921f1587 (on main f5e9be367).
  • Run state: finished (local); hosted CI pending on this PR.
  • Input classes: synthetic
Check kind Result Public-safe evidence / limitation
focused_unit passed tests/test_cli_argument_diagnostics.py: 104 passed.
regression_parity passed On main the old test fails for update and complete. With the validator put back to claim-only, the new test fails for update and complete.

Frontend / Visual Evidence

  • UI impact: none (test only).

Type of Change

  • Test update

LoopX Area

  • Build, packaging, installer, or CI

Shared-authority RFC fixture impact

N/A

Boundary Checklist

  • Neither the diff nor this PR body/comments/attachments disclose private state, credentials, raw traces or verifier output, internal links, or local machine paths.
  • I did not duplicate maintainer-owned benchmark work.
  • I kept the change scoped to the linked issue/task.
  • No paired RFC changed.
  • UI impact none.
  • Every commit includes a DCO Signed-off-by trailer.

🤖 Generated with Claude Code

…roject#7510

loopx-project#7510 lets todo update and todo complete carry --claim-operation-id so
they can settle a managed execution lease, but the shared-option test
still expected both to reject it. Every main test run since then fails
two shards on those parametrizations.

Keep the rejection for add, list and supersede against the current
message, and assert that claim, update and complete accept the option.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Lihua <1017343802@qq.com>
@mergify

mergify Bot commented Oct 28, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @LIHUA919.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Oct 28, 2026
@LIHUA919

Copy link
Copy Markdown
Contributor Author

Superseded by #7572, which merged the same fix for test_claim_operation_id_is_not_silently_ignored_by_other_commands (and also asserts the raw reference is retained). Closing this duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant