Repository navigation
Conversation
…roject#7510 loopx-project#7510 lets todo update and todo complete carry --claim-operation-id so they can settle a managed execution lease, but the shared-option test still expected both to reject it. Every main test run since then fails two shards on those parametrizations. Keep the rejection for add, list and supersede against the current message, and assert that claim, update and complete accept the option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lihua <1017343802@qq.com>
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
|
Superseded by #7572, which merged the same fix for |
Goal And Delivered Outcome
test-shardjobs onmain. Each one fails attests/test_cli_argument_diagnostics.py::test_claim_operation_id_is_not_silently_ignored_by_other_commandswithDID NOT RAISE ValueError. This happened on the scheduled run at9558f75ae(shards 1 and 2) and the push run at5a65338fa(shard 4). Each shard hits whicheverupdate/completeparametrizations it was assigned.validate_shared_todo_options, sotodo updateandtodo completenow accept--claim-operation-id(to settle a managed execution lease). The message became "supported only by todo claim/update/complete". The test still listsupdateandcompleteas commands that must reject the option.add,listandsupersedeand matches the current message. A new test asserts thatclaim,updateandcompleteaccept the option. No product code changed.update/completeparametrizations stop failingmain, and the widened behavior from fix(tasks): manage execution leases through ordinary task operations #7510 is now covered by a test.main.Author Declaration
Implemented against
loopx/cli_commands/todo_argument_validation.pyas of fix(tasks): manage execution leases through ordinary task operations #7510, which accepts--claim-operation-idforclaim,updateandcomplete.test_claim_operation_id_is_not_silently_ignored_by_other_commandspytest tests/test_cli_argument_diagnostics.pytest_claim_operation_id_is_shared_by_lease_bound_commandsupdateandcomplete.Scope And Continuation
mainfailures,tests/test_native_steward_reports.py::test_original_pump_resumes_exact_prelaunch_rejection_once_without_replaying_unknown_work[False-file](IndexError, one shard) andtests/test_lark_private_conversations.py::test_app_long_return_keeps_all_parts_and_does_not_repeat_identical_parts(one shard). Each failed only once, so this PR leaves them alone.Validation
d921f1587(onmainf5e9be367).focused_unitpassedtests/test_cli_argument_diagnostics.py: 104 passed.regression_paritypassedmainthe old test fails forupdateandcomplete. With the validator put back to claim-only, the new test fails forupdateandcomplete.Frontend / Visual Evidence
Type of Change
LoopX Area
Shared-authority RFC fixture impact
N/A
Boundary Checklist
none.Signed-off-bytrailer.🤖 Generated with Claude Code