chore: Sync account schemas - #1072
Open
lightspark-copybara[bot] wants to merge 1 commit into
Open
lightspark-copybara[bot] wants to merge 1 commit into
lightspark-copybara[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
github-actions
Bot
added
the
breaking-change
Contributor
|
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
6
to
7
| required: | ||
| - bankAccountType | ||
| - beneficiary |
Contributor
There was a problem hiding this comment.
Removing bankAccountType from this required list makes a USD external-account request without CHECKING or SAVINGS valid under the OpenAPI contract. The existing endpoint examples, integration guide, and changelog still require this value because Grid uses it to select the ACH transaction code. Generated clients will therefore allow incomplete requests that the API must reject or cannot route correctly. Keep the property in the shared base if needed, but require it here for UsdExternalAccountCreateInfo.
Suggested change
| required: | |
| - bankAccountType | |
| - beneficiary | |
| required: | |
| - bankAccountType | |
| - beneficiary |
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/UsdExternalAccountCreateInfo.yaml
Line: 6-7
Comment:
**Account type no longer required**
Removing `bankAccountType` from this `required` list makes a USD external-account request without `CHECKING` or `SAVINGS` valid under the OpenAPI contract. The existing endpoint examples, integration guide, and changelog still require this value because Grid uses it to select the ACH transaction code. Generated clients will therefore allow incomplete requests that the API must reject or cannot route correctly. Keep the property in the shared base if needed, but require it here for `UsdExternalAccountCreateInfo`.
```suggestion
required:
- bankAccountType
- beneficiary
```
**Knowledge Base Used:**
- [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)
- [Customers and accounts API](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/customers-and-accounts-api.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)mintlify/snippets/corridor-required-fields.mdx— per-corridor required fields tablemintlify/corridor-fields.js— filter script for that tablePlease review the changes before merging.