chore: Sync account schemas - #1057
lightspark-copybara[bot] wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-cli studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-python studio · code · diff
✅ grid-php studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| required: | ||
| - bankAccountType | ||
| - beneficiary |
There was a problem hiding this comment.
Moving bankAccountType into the optional shared base removes it from this create schema's required fields. All three USD external-account creation operations now allow clients to omit it, even though Grid uses the value to select the ACH transaction code. A savings account submitted without it can be treated as checking and cause the receiving bank to issue a notification of change.
| required: | |
| - bankAccountType | |
| - beneficiary | |
| required: | |
| - bankAccountType | |
| - beneficiary |
Knowledge Base Used: Grid API contract
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/UsdExternalAccountCreateInfo.yaml
Line: 6-7
Comment:
**Required account type removed**
Moving `bankAccountType` into the optional shared base removes it from this create schema's required fields. All three USD external-account creation operations now allow clients to omit it, even though Grid uses the value to select the ACH transaction code. A savings account submitted without it can be treated as checking and cause the receiving bank to issue a notification of change.
```suggestion
required:
- bankAccountType
- beneficiary
```
**Knowledge Base Used:** [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| @@ -13,13 +13,3 @@ allOf: | |||
| - WIRE | |||
| - RTP | |||
| - FEDNOW | |||
There was a problem hiding this comment.
Moving this response field into the shared base removes the explanation that bankAccountType can be absent from accounts created before the field became required. The property remains optional, but integrations no longer receive the compatibility guidance and may misdiagnose valid legacy responses.
Knowledge Base Used: Grid API contract
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/UsdAccountInfo.yaml
Line: 15
Comment:
**Legacy absence guidance removed**
Moving this response field into the shared base removes the explanation that `bankAccountType` can be absent from accounts created before the field became required. The property remains optional, but integrations no longer receive the compatibility guidance and may misdiagnose valid legacy responses.
**Knowledge Base Used:** [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
|
Superseded by #1072 |
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)mintlify/snippets/corridor-required-fields.mdx— per-corridor required fields tablemintlify/corridor-fields.js— filter script for that tablePlease review the changes before merging.