Repository navigation
Polish hosted Terminal appearance and add review stories - #111
Merged
Merged
Conversation
stevejuma
marked this pull request as ready for review
November 20, 2026 01:46
Co-authored-by: lapismd-dependency-bot[bot] <351186875+lapismd-dependency-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server terminals gain bundled JetBrains Mono regular/bold at 14px through the Terminal plugin's public font options. Eight production-hosted stories cover light/dark prompts, failures, nested directories and independent sessions. Stories start with collapsed sidebars and verify actual canvas colours, exact theme backgrounds and full-width geometry. Open Terminal restores a retained terminal when the panel is closed and creates a new terminal when one is visible; the panel also offers explicit New Terminal and numbered tabs.
Consumes published
@lapis-notes/lapis-plugin-terminal@^0.1.1, locked to 0.1.1, following merged lapismd/lapis-plugin-terminal#5 and release v0.1.1. Terminal privately bundles its maintained Ghostty Web 0.4.0 source backport, matching JavaScript/WASM, licence and provenance. Server removes its obsolete nested Ghostty optimizer input and requires no patch, archive hook or source alias. coder/ghostty-web#232 remains the patch-removal path.Registry-only validation: the original check improves from two TypeScript errors to zero errors/warnings; 16 focused terminal cases, 227 units, 132 dependency/CLI/release tooling checks, all 92 catalog interaction/accessibility cases, two cold reload/real-keyboard cases and five built-static browser cases pass. Application/static Storybook builds, canonical spec, dependency intake, App ownership and formatter pass. Cold acceptance uses a fresh Storybook process, five mounts per theme at DPR 2, actual Reload story and real keyboard pwd input preserving the full UUID. The Linux pixel-classifier failure is reproduced as 12 failures/four passes, then all 16 pass in the same isolated frozen Linux environment after requiring each intended ANSI colour while retaining the existing aggregate minimum. Failure stories additionally require red status pixels. Evidence: spec/records/2026-11-20-terminal-registry-adoption.md. The temporary archive hook is retired; ordinary frozen npm-registry installs qualify the package.
Desktop shell/font defaults are unchanged. Coloured compact prompts/listings in these stories are disposable ANSI fixtures; native Server Bash profile work and actual image/PTY qualification for that profile remain documented follow-up work. No visual baselines were updated.
Hosted Node-24 CI run 44652944907 passes all selected/required checks, including the complete production catalog, startup budget, all seven hosted browser suites and native plugin-operation acceptance.