Repository navigation
Conversation
This was referenced Nov 19, 2026
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSC 10/11 default-colour changes currently leave resolved VT cells in the previous colours, and FitAddon reserves a 15px gutter even though the scrollbar overlays the canvas. This updates the WASM response stream to apply colour operations and makes the renderer fill the measured viewport, including partial-cell space, without stretching character metrics. Scrollbar drawing and hit testing now meet the right edge.
Adds regressions for existing default cells versus explicit backgrounds, full-width fitting, and viewport changes that do not change the column count. Theme changes repaint the viewport remainder, and canvas sizing remains owned by the renderer at device pixel ratio.
Validation: 361 tests pass; formatting, lint, TypeScript and the normal library/WASM build pass. Consumer Chromium checks at DPR 2 cover theme pixels, repeated remounts, full-width geometry and right-edge scrollbar input. The WASM build used Zig 0.15.2 in a disposable Linux container because the local macOS SDK could not link the Zig build runner.
Downstream integration: the renderer lifetime/theme/viewport changes were accepted in lapismd/lapis-plugin-terminal#5 and shipped in Terminal 0.1.1. Terminal maintains a version-pinned 0.4.0 source backport while this upstream change awaits review and bundles matching JavaScript/WASM for consumers. Server adoption is tracked in lapismd/lapis-server#111. Registry-only acceptance passes all 16 terminal stories, 92 catalog interaction/accessibility cases, two fresh-process reload/real-keyboard cases and five static browser cases. The upstream source fix in this PR remains unchanged; an upstream release is the maintained patch's removal path.