Skip to content

fix: update default colors and fill the terminal viewport - #232

Open
stevejuma wants to merge 2 commits into
coder:mainfrom
stevejuma:fix/default-colors-and-viewport
Open

stevejuma wants to merge 2 commits into
coder:mainfrom
stevejuma:fix/default-colors-and-viewport

Conversation

@stevejuma

@stevejuma stevejuma commented Nov 19, 2026 •

Copy link
Copy Markdown

OSC 10/11 default-colour changes currently leave resolved VT cells in the previous colours, and FitAddon reserves a 15px gutter even though the scrollbar overlays the canvas. This updates the WASM response stream to apply colour operations and makes the renderer fill the measured viewport, including partial-cell space, without stretching character metrics. Scrollbar drawing and hit testing now meet the right edge.

Adds regressions for existing default cells versus explicit backgrounds, full-width fitting, and viewport changes that do not change the column count. Theme changes repaint the viewport remainder, and canvas sizing remains owned by the renderer at device pixel ratio.

Validation: 361 tests pass; formatting, lint, TypeScript and the normal library/WASM build pass. Consumer Chromium checks at DPR 2 cover theme pixels, repeated remounts, full-width geometry and right-edge scrollbar input. The WASM build used Zig 0.15.2 in a disposable Linux container because the local macOS SDK could not link the Zig build runner.

Downstream integration: the renderer lifetime/theme/viewport changes were accepted in lapismd/lapis-plugin-terminal#5 and shipped in Terminal 0.1.1. Terminal maintains a version-pinned 0.4.0 source backport while this upstream change awaits review and bundles matching JavaScript/WASM for consumers. Server adoption is tracked in lapismd/lapis-server#111. Registry-only acceptance passes all 16 terminal stories, 92 catalog interaction/accessibility cases, two fresh-process reload/real-keyboard cases and five static browser cases. The upstream source fix in this PR remains unchanged; an upstream release is the maintained patch's removal path.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant