[lgelauff]

Finalizing the ranking round with the round's own button left the campaign impossible to finalize, and so without a report (#644). This PR fixes that, and makes the two ways to close a campaign visible on the campaign page.

It builds on two contributions, credited as co-authors of the first commit: @SSpirate11 (#672) and @ademolaomosanya (#408). Thank you both.

Backend

finalize_campaign (admin_endpoints.py):

• also accepts a campaign whose last round is a finalized ranking round. It stores the results summary from that round and leaves the round itself alone (the Finalizing the ranking round with its own button makes the campaign impossible to finalize #644 case, from fix(admin): allow campaign finalization after ranking round is finali… #672);
• refuses a campaign that is already finalized (from fix(admin): allow campaign finalization after ranking round is finali… #672).

A finalized campaign keeps meaning "its final results are stored", as decided in #169. So a campaign that ends on a yes/no or rating round is still refused, now with a hint to archive it instead. Whether such campaigns should get a report is #680.

save_results_summary (rdb.py) is split out of finalize_ranking_round. It updates the campaign's one summary instead of adding a second one, so a reopened campaign can be finalized again (from #672).

Finalizing before any ranking ballot is in now returns a 400 ("no ranking ballots have been submitted yet") instead of a 500 (#681). With no ballots, get_round_ranking_list used to pass an empty list to SchulzeNPR, which recursed until RecursionError. It now returns an empty ranking for that case.

Frontend (campaign page)

• Close with report: finalize. Shown only while the campaign is active and its last round is a ranking round.
• Close without report: archive. "Archive" keeps its label for finalized campaigns, and Reopen unarchives.
• Help text when no report is possible: a report needs a ranking round as the last round, and the results of each round stay on the round page.
• New i18n keys, documented in qqq.json.
• The rroundResults typo fix, which shows the cancelled-task count again (from fix: allow closing campaign after any finalized round #408).

Tests

montage/tests/test_finalize_campaign.py, 6 tests:

• the Finalizing the ranking round with its own button makes the campaign impossible to finalize #644 sequence: the report has the winners, and the round keeps its close date;
• finalizing twice is refused;
• reopening and finalizing again leaves one summary;
• a campaign that ends on a yes/no round is refused;
• finalizing before any ballot is refused, on both paths.

All 6 fail on master. Full suite: 177 passed, 3 xfailed. Frontend lint, prettier and build pass.

Checked in a headless browser against local dev servers: the buttons and help text for a campaign ending on a ranking round, one ending on a yes/no round, and an archived campaign. Not checked: the finalized state with a real report.

Fixes #644. Fixes #681. Supersedes #672 and #408. #143 is covered by archiving; see the comment there.

Written by Claude (Claude Code) on behalf of @lgelauff.

🤖 Generated with Claude Code