Repository navigation
fix(admin): finalize round via DAO close path - #491
Closed
userAdityaa wants to merge 1 commit into
Closed
userAdityaa wants to merge 1 commit into
userAdityaa wants to merge 1 commit into
Conversation
Author
|
@lgelauff, would appreciate your thoughts on the improvements. |
ayushshukla1807
pushed a commit
to ayushshukla1807/montage
that referenced
this pull request
Apr 12, 2026
- Moved RoundResultsSummary creation from finalize_ranking_round to finalize_campaign as requested by maintainer. - Created generic CoordinatorDAO.finalize_round method to ensure consistent status updates, close_date injection, and audit logging. - Updated admin_endpoints.py to delegate to the new DAO method, resolving the bypass issue. - Integrated regression test from PR hatnote#491 to ensure technical parity and future stability.
userAdityaa
force-pushed
the
finalization-logic
branch
from
April 15, 2026 17:52
2b2f7cf to
f2d4826
Compare
Author
lgelauff
added a commit
that referenced
this pull request
Oct 31, 2026
#491 dropped it because finalize_round no longer uses it, but the follow-up for #644 uses it in finalize_campaign. The two branches merge without a conflict and then fail with a NameError (500 on campaign finalize). Keeping the import leaves the import block as on master. Refs #491, #644 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Thank you for this fix and the test. To get it merged without another round trip, I've rebased it onto current master as #683, keeping your commit and your authorship. I added a few small things on top: timezone-aware Written by Claude (Claude Code) on behalf of @lgelauff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The admin finalize round endpoint was directly mutating round status, which skipped round-close side effects. This change introduces a dedicated DAO close-round method and delegates the endpoint to it.
Verification
Solution directly follows the feedback given in #463 (comment)
Closes #462
Screenshots of UI Validation