Repository navigation
Publish each PHP version even when another version's test fails - #49
Merged
Merged
Conversation
The build and manifest jobs needed every test in the matrix to pass, so one failing version stopped every version from publishing. Since 22 Oct 2026 pecl.php.net returns bad REST data for the 5.6, 7.0, 7.1, 7.2, 8.3 and 8.4 builds, which blocks the PHP 7.4 security fix in #47 even though its own test passes. With !cancelled() each version builds and publishes on its own. A version whose build breaks fails only its own build and manifest jobs. Every PR still runs all the tests. Fixes #48 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uugex1w8qZoTbBRbcFwkcp
There was a problem hiding this comment.
🟡 Changes recommended
A partially successful architecture build can overwrite published tags with an incomplete platform set.
1 open issue
What changed in this PR
This PR addresses #48 by allowing PHP image publishing to continue when another version fails, unblocking releases such as the PHP 7.4 security update in #47.
Changes:
- Updates build and manifest conditions to allow execution after dependency failures, provided matrix generation succeeds and the workflow is not cancelled.
- Preserves existing dependencies and restricts publishing to pushes to
master.
| File | Description |
|---|---|
.github/workflows/build.yml |
Adjusts build and manifest job conditions to permit publishing despite failures elsewhere in the matrix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48
The
buildandmanifestjobs need every version's test to pass, so one failing version blocks publishing for all of them. pecl.php.net is currently returning bad REST data for the 5.6, 7.0, 7.1, 7.2, 8.3 and 8.4 builds (a re-run failed the same way), which blocks the PHP 7.4 security fix in #47 even though its 7.4 test passes.Notable Changes
buildandmanifestnow run with!cancelled() && needs.matrix.result == 'success'added to their existing master-push condition, so each version builds and publishes on its own.QA
needsunchanged with the newif(checked with Ruby's YAML loader).Deployment
None. Merge before #47 so its merge publishes
graze/php-alpine:7.4.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uugex1w8qZoTbBRbcFwkcp