Skip to content

fix: use the x circle icon for the error inline banner #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ignaciocapodanno merged 1 commit into from
Oct 27, 2026
Merged

fix: use the x circle icon for the error inline banner #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/assets/icons/xCircleFilled.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/components/inlineBanner/inlineBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const bannerConstants: Record<InlineBannerTypes, BannerConstants> = {
error: {
backgroundColor: palette.red.shade20,
iconColor: palette.red.shade40,
icon: 'WarningFilled'
icon: 'XCircleFilled'
},
warning: {
backgroundColor: palette.orange.shade20,
Expand Down
4 changes: 3 additions & 1 deletion src/elements/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ import Trash from '../../assets/icons/trash.svg';
import TrashFilled from '../../assets/icons/trashFilled.svg';
import UserSquare from '../../assets/icons/userSquare.svg';
import WarningFilled from '../../assets/icons/warningFilled.svg';
import XCircleFilled from '../../assets/icons/xCircleFilled.svg';
import {greys} from '../../helpers/colorHelpers';
import {getIconViewBox} from './iconViewBoxes';

Expand Down Expand Up @@ -127,7 +128,8 @@ const importedIcons = {
Trash,
TrashFilled,
UserSquare,
WarningFilled
WarningFilled,
XCircleFilled
} as const;

export type IconName = keyof typeof importedIcons;
Expand Down
Loading