[ignaciocapodanno]

Description

The error inline banner shows the warning triangle, the same glyph as the warning banner, with only the color telling them apart. The front-client design system already uses an x circle for error, so the kit is the one out of date.

This adds the XCircleFilled icon and uses it for the error type. The asset is the same one front-client ships (x-circle-filled-16.svg), with its hardcoded fill swapped for currentColor so the kit can color it. Only error changed, warning keeps the triangle.

Note that info and success still differ from the design system too (InfoFilled and CheckmarkCircle against info-circle/filled/16 and check-circle/filled/16). Left out of this PR to keep it narrow, happy to follow up.

Links

Jira
Styleguide

Screenshot

Risks and recovery

Visual only, and it reaches every error banner in every consumer of the kit. No feature flag. Reverting the commit is enough.

Checklist:

• I have performed a self-review of my own code.
• I have added or updated tests to cover my changes, or explained why not.
• I have manually tested my change on staging / canaried my change, or explained why not.

Testing

• No tests added. inlineBanner has no test file today, and icon.spec.tsx does not enumerate the icon registry, so the existing suite does not cover this either way.
• yarn typecheck: passes. yarn lint: 0 errors, 1 pre existing warning in card.tsx. yarn test: 68 tests and 47 snapshots pass.
• Checked both stories in Storybook: the error banner shows the x circle in medium and small, the warning banner still shows the triangle.