Repository navigation
feat: build the MPEG-4 Visual reference decoder (vm_dec) - #413
Conversation
5ad89a5 to
0c7d66c
Compare
It should be enabled for other platforms and tested in the CI |
fd0b62e to
4e3dbbc
Compare
Done, tested here https://github.com/fluendo/fluster/actions/runs/40315200021 |
4e3dbbc to
b05b7c5
Compare
381af9a to
0bfa9b2
Compare
229bc78 to
16f1d45
Compare
16f1d45 to
fc61e23
Compare
mdimopoulos
left a comment
mdimopoulos
left a comment
There was a problem hiding this comment.
I've tried to test with ref decoder in MacOS (aarch64) without success.
It seems that the decoder binary is built correctly, however when i ./fluster.py r -d ISO-MPEG4-VIDEO -s -v i get
* test_suites_dir: /Users/midimopo/Work/Repos/fluster/fluster/../test_suites
* resources_dir: /Users/midimopo/Work/Repos/fluster/fluster/../resources
* output_dir: /var/folders/gj/20q2p6w15b1gqj1fw5lkbjrw0000gn/T/fluster_output
when i executed the same with FFmpeg MPEG4 decoder i got the usual fluster report.
I wouldn't block the PR for this though
fc61e23 to
6aaf537
Compare
This is by design, the mpeg4_video test suite uses the pixel comparision method and reference decoders are skipped with that configuration. We should probably write better logs to inform that |
Enabled by default like the other reference decoders (-Dmpeg4_video_decoder=false to disable). download_deps.py fetches the ISO sources and adapts them to current compilers; no ISO code is committed. Built in CI on Linux (x86_64, ARM64), macOS (ARM64) and Windows (MSYS2)
6aaf537 to
959bf21
Compare
PR to try to solve this issue #348
Only tested on linux (x86_64)