Repository navigation
build: create subproject links as directories on Windows - #419
Merged
Merged
Conversation
ylatuya
force-pushed
the
fix/windows-subproject-links
branch
6 times, most recently
from
November 3, 2026 12:36
de609bb to
38a9f34
Compare
rsanchez87
requested review from
rsanchez87
and removed request for
rsanchez87
November 3, 2026 13:21
A plain symlink_to creates a file symlink on Windows, which Meson cannot use as a subproject directory. It then falls back to the stub .wrap file, which has no source_filename, and disables the subproject. This silently skipped the reference decoders that use local subprojects on Windows. Use a junction on Windows and a symlink elsewhere, and verify that the link resolves to a directory. Junctions do not need developer mode or SeCreateSymbolicLinkPrivilege and are always seen as directories. Install make on the Windows CI image for the existing MPEG-4 AAC build, and skip the MPEG-4 AAC ER decoder there because it is a separate known Windows failure (sys/wait.h). Copy MinGW .exe decoder binaries with their extension and verify all expected reference decoders in CI.
ylatuya
force-pushed
the
fix/windows-subproject-links
branch
from
November 3, 2026 16:07
38a9f34 to
14b9d0c
Compare
rsanchez87
reviewed
Nov 4, 2026
rsanchez87
self-requested a review
November 5, 2026 15:27
rsanchez87
approved these changes
Nov 5, 2026
ylatuya
changed the title
Contributor
Author
|
The commit should have been 'build' instead of 'fix', sorry :( |
Contributor
I'm sorry I didn't detect that... at least having commit of #421 as build, we can have better the changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Windows reference decoder builds.
Path.symlink_to()creates a file symlink by default on Windows, so Meson cannot usesubprojects/<name>as a subproject directory. It falls back to the stub.wrapfile, which has nosource_filename/source_url, and disables the subproject with:The job stayed green because the subprojects are optional, while the decoders that use them were silently skipped on Windows.
This PR:
makeon the Windows CI image, which the existing MPEG-4 AAC build still needs;.exedecoder binaries with their extension, somp4audec_mcis actually published;sys/wait.h), unrelated to the subproject links;This is independent of any decoder change. It fixes the local subproject links used by MPEG-2 video, MPEG-2 AAC, libtsp and MPEG-4 Visual.