Repository navigation
fix: resolve high-value CPAN compatibility issues - #1881
Merged
Merged
Conversation
Match Perl's `.=` warning behavior while keeping an undefined left operand quiet. Add system-Perl-compatible coverage for warnings, fatal warnings, source locations, and localized STDOUT capture. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+codex@users.noreply.github.com>
Keep intermediate list-valued call results alive with counted scalar owners while later argument expressions run. This preserves Rose form weak parent links until add_forms consumes its arguments. Add regression coverage for nested weak parent links and qualified form and field names, and record the Rose fix in the changelog. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <chatgpt-codex@users.noreply.github.com>
fglock
changed the title
fglock
marked this pull request as ready for review
October 24, 2026 17:53
Bring the CPAN compatibility branch up to the latest master while preserving both changelog entries and all verified changes. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <chatgpt-codex@users.noreply.github.com>
Use a platform-native temporary directory for the remove_tree regression and normalize Windows text-mode newlines in the localized STDOUT assertion. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <chatgpt-codex@users.noreply.github.com>
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
add_formsconsumes them (Rose::HTML::Objects t/form-nested.t fails with nested field names and values #1851)..=while keeping an undefined left operand quiet.Verification
nice -n 19 make— passed.make check-links— passed.prove src/test/resources/unit/weak_nested_form_argument_lifetime.t— 29/29 passed with system Perl; the same test passes on JVM and interpreter.t/form-nested.t.t/08_global_vars.tpasses 4/4 andt/39_line_info.tpasses 15/15 on both backends.t/104_override_usage.tpasses 7/7 andt/109_help_flag.tpasses 22/22 on both backends, using the existing Test::Trap distropref patches.t/encoding.tpasses 25/25 on both backends, including the exact quoted-printable raw-body assertion.