Skip to content

conformance: match SolDB's numbered breakpoint output and pin to v0.3.0 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnidan merged 1 commit into from
Sep 15, 2026
+7 −4
Merged

conformance: match SolDB's numbered breakpoint output and pin to v0.3.0 #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ethdebug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
required: true
soldb_ref:
description: SolDB ref to build
default: main
default: v0.3.0
required: true

concurrency:
Expand All @@ -28,7 +28,7 @@ concurrency:
env:
FOUNDRY_VERSION: v1.0.0
SOLIDITY_REF: ${{ github.event.inputs.solidity_ref || 'develop' }}
SOLDB_REF: ${{ github.event.inputs.soldb_ref || 'main' }}
SOLDB_REF: ${{ github.event.inputs.soldb_ref || 'v0.3.0' }}

jobs:
conformance:
Expand Down
7 changes: 5 additions & 2 deletions packages/conformance/src/adapters/soldb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,11 @@ export function observeSourceBreakpoint(
target: string,
): { set: boolean; hit: boolean; stoppedAtTarget: boolean } {
return {
set: result.stdout.includes(`Breakpoint set at ${target}, PC`),
hit: result.stdout.includes("Breakpoint hit at step"),
// SolDB numbers breakpoints, e.g. `Breakpoint #1 set at Counter.sol:8` and
// `Breakpoint #1 hit at step 88, Counter.sol:8, PC 558`, so match the stable
// fragments rather than an exact, unnumbered prefix.
set: result.stdout.includes(`set at ${target}`),
hit: /Breakpoint #\d+ hit at step/.test(result.stdout),
stoppedAtTarget: result.stdout.includes(`${target}, PC`),
};
}
Expand Down
Loading