conformance: match SolDB's numbered breakpoint output and pin to v0.3.0 - #294
Merged
Merged
Conversation
The source-line breakpoint check parsed for `Breakpoint set at <t>, PC` and `Breakpoint hit at step`, but SolDB numbers its breakpoints and prints `Breakpoint ethdebug#1 set at Counter.sol:8` and `Breakpoint ethdebug#1 hit at step 88, Counter.sol:8, PC 558`. The `ethdebug#1` broke both substring matches, so the observer reported the breakpoint neither set nor hit even though SolDB stopped at the line. Match the stable fragments instead. The consumer conformance also built SolDB from `main`; pin it to the v0.3.0 release so the check runs against a stable, published debugger.
Contributor
Author
|
cc @gnidan |
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source-line breakpoint check parsed for
Breakpoint set at <t>, PCandBreakpoint hit at step, but SolDB numbers its breakpoints and printsBreakpoint #1 set at Counter.sol:8andBreakpoint #1 hit at step 88, Counter.sol:8, PC 558. The#1broke both substring matches, so the observer reported the breakpoint neither set nor hit even though SolDB stopped at the line. Match the stable fragments instead.The consumer conformance also built SolDB from
mainso now we pin it to thev0.3.0release so the check runs against a stable, published debugger.We will keep increasing the release version as we make future releases.