Repository navigation
"Delete from iPhone" on a kept Take in the moves list (#656) - #905
Merged
Merged
Conversation
A Take the moves keep on the iPhone gets a button that asks the Kit whether the Drive holds everything the iPhone holds of it, then confirms in words that name the Take, its Stems and their lengths, that the Drive copy stays and that it can't be undone on the iPhone. Disabled during a Take or a save. The words live in the Kit (DeviceTakeRelease.Summary) so they are tested. Claude-Session: https://claude.ai/code/session_01Wx6Spsz6BcTiKDzUUP9CzN
Skeyelab
enabled auto-merge (squash)
October 21, 2026 03:26
…656) It deletes the Device's copy of a Take, so it ships hidden behind DeviceTakeDeleteAvailability until Eric has tried it on a device; raising it is that one rule. Claude-Session: https://claude.ai/code/session_01Wx6Spsz6BcTiKDzUUP9CzN
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Oct 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#656, PR 3 of 3 (#865 the check, #866 the Kit action). Closes the issue.
A kept Take in the moves list (
MoveReportSheet) gets a Delete from iPhone button (ThisHardware.word). Tapping it runsRecorder.checkRelease: "Checking the Drive…", then, only if the Drive holds everything the Device holds of the Take, a confirmation that names the Take, its Stems and their lengths, says the Drive copy stays and that it can't be undone on this iPhone. If the check fails: "Not deleted. The Take stays on this iPhone." plus the Kit's first reason. The button is disabled during a Take, a save or a move, with "Available once the current Take is saved."; the Kit refuses in those states too.Availability (cos, per CLAUDE.md): hidden behind
DeviceTakeDeleteAvailability, Debug + TestFlight only, never the App Store build, until Eric has tried it on a device. Raising it is a one-line PR.Wording: proposed by me, reviewed and edited by agent3 (copy owner). It lives in
DeviceTakeRelease.Summary.title/message(Kit) so it is tested (DeviceTakeReleaseWordsTests).VERIFYfull passes (package tests, macOS build and AppTests, iOS Simulator build). Not tried on a device or in the Simulator: the row, dialog and states are checked by build only. Eric should try it on the iPhone with a kept Take; delete is real and permanent on the iPhone, though the Drive copy is verified twice first.Closes #656
https://claude.ai/code/session_01Wx6Spsz6BcTiKDzUUP9CzN