Skip to content

Delete from iPhone is Debug only until Eric has tried it (#656) - #909

Merged
Skeyelab merged 1 commit into
mainfrom
fix/delete-debug-only
Oct 21, 2026
Merged

Skeyelab merged 1 commit into
mainfrom
fix/delete-debug-only

Conversation

@Skeyelab

Copy link
Copy Markdown
Member

Eric chose Debug only for DeviceTakeDeleteAvailability (was Debug + TestFlight, #905).

  • Red first: the new releaseBuild test failed while the rule still offered it for .sandbox.
  • isAvailable now returns isDebugBuild; the environment parameter stays so moving it up to TestFlight is a separate one-liner after Eric tries it on a device.
  • A stale comment in App/StatusStrip.swift now says Debug only (comment only).

Checked only by tests (quick verify passed; app builds left to CI), not on a device. Code Reviewer found no blockers.

DeviceTakeDeleteAvailability no longer offers it in TestFlight builds. The
environment parameter stays so raising the level is a one-line change.
Checked only by tests; the App/ change is a comment.

Assisted-by: Claude Code:claude-sonnet-5-5
@Skeyelab
Skeyelab enabled auto-merge (squash) October 21, 2026 18:28
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Skeyelab
Skeyelab merged commit db54ab7 into main Oct 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant