Repository navigation
warm-root: list the prefetch from a launch that restores the snapshot - #1397
Conversation
On the first host booted from the ce08eee AMI the prefetch list held 6163 files (334 MiB) and fcvm-fleet-prefetch.service ran for 20 s (17.8 s of CPU) beside cloud-init-local (9.3 s, against 7.4 s on the image before) and the store (13.6 s, against 10.8 s). warm-root.sh traced its only launch, which also boots the VM and exports the image into root's podman store, so the list held image layers no slot reads. On a leased g4dn.metal, the traced launch of a slot that restores the snapshot read 120 files (124 MiB). warm-root.sh now launches twice: the first takes the pre-start snapshot, the second runs under strace, must log a pre-start snapshot hit, and is what the list comes from. Test: fleet/ami/check.sh asserts the traced launch follows an untraced one and the hit is checked (fails against the previous warm-root.sh). the_ami_warm_up_launches_its_vm_as_a_slot_is_launched passes.
|
@codex review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41cdc347f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8acd837c92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcvm logs 'Pre-start snapshot hit' before it loads the snapshot, and a load that fails is logged as 'Snapshot miss' and cold-boots, which also reaches a first frame (Codex, #1397). Each launch now logs to its own file, and the traced launch's must hold the hit and no miss. Test: fleet/ami/check.sh requires that check (fails against 8acd837).
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
On the first host booted from the ce08eee AMI the prefetch list held 6163
files (334 MiB) and fcvm-fleet-prefetch.service ran for 20 s (17.8 s of
CPU) beside cloud-init-local (9.3 s, against 7.4 s on the image before)
and the store (13.6 s, against 10.8 s). warm-root.sh traced its only
launch, which also boots the VM and exports the image into root's podman
store, so the list held image layers no slot reads. On a leased
g4dn.metal, the traced launch of a slot that restores the snapshot read
120 files (124 MiB).
warm-root.sh now launches twice: the first takes the pre-start snapshot,
the second runs under strace, must log a pre-start snapshot hit, and is
what the list comes from.
Test: fleet/ami/check.sh asserts the traced launch follows an untraced
one and the hit is checked (fails against the previous warm-root.sh).
the_ami_warm_up_launches_its_vm_as_a_slot_is_launched passes.
Contract: the host AMI's prefetch list names what a woken slot's launch reads, not what the AMI build's first launch reads. Downstream: the next host AMI build. Evidence above; the list size on a built image is checked when that AMI is built.