Repository navigation
fleet: viewers read a fixed sentence when the word check cannot answer - #1372
Conversation
A viewer who wrote a word on staging read "the text check failed: no text check is configured": apply.rs prefixed the checker's own error, and that error also went into the receipt's check and the public failures list, where a Bedrock error would name the model, region or AWS message. - text_check.rs: an error verdict's reason is "words are turned off right now" for --text-check none (NoCheck answers with a Disabled error) and "couldn't check that word, try again" for any other error or the 5 s timeout. The error itself is logged at warn. - apply.rs: an error verdict refuses with its reason as is. - 07_words.json vector and the web fixture regenerated from it, PROTOCOL.md. - Tests: viewers_read_a_fixed_reason_not_the_checker_error, without_a_text_check_viewers_read_that_words_are_off, and a_failing_text_check_degrades_the_coordinator now requires the fixed reason in the receipt, its check and the failures list. Each fails on the old behavior.
|
@codex review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A viewer word that the text check could not judge now reads as one of two fixed sentences instead of the checker's internals. On staging, typing "Hi!" showed
"Hi!" was not added: the text check failed: no text check is configured.Change
src/fleet/coord/text_check.rs: anerrorverdict's reason iswords are turned off right nowwhen the coordinator runs with--text-check none(NoChecknow answers with aDisablederror), andcouldn't check that word, try againfor any other error or the 5 s timeout. The error itself goes to the coordinator log at warn (text check failed error=...). The reason reaches the receipt, itscheck, the actions feed and thecoordinator_degradedfailure, all public.fleet/core/src/apply.rs: anerrorverdict refuses with its reason as is, without thethe text check failed:prefix. Hide AWS account ids in the errors the wall's view shows #1362's account-id redaction still runs over it.fleet/core/tests/vectors/07_words.json, the web fixture regenerated from the vectors (one summary changes),fleet/PROTOCOL.md.Staging also needs the checker turned on: ejc3/aws#707 sets
--text-check bedrockwithus.anthropic.claude-haiku-5-5in us-west-2 and grants the coordinator's task rolebedrock:InvokeModel. Until that is applied, staging viewers read "words are turned off right now".Tests
Each fails on the base behavior and passes here:
viewers_read_a_fixed_reason_not_the_checker_error(unit):NoCheckgivesWORDS_OFF, a failing checker givesCHECK_FAILED.a_slow_check_times_out_as_an_error: a timeout givesCHECK_FAILED.without_a_text_check_viewers_read_that_words_are_off(coordinator over its WebSocket): the receipt reason isWORDS_OFF.a_failing_text_check_degrades_the_coordinator: the receipt, its check and the failures entry carryCHECK_FAILED, not "fake text check is down". It previously asserted the checker's error reached the failures list.replayed_vectors_hold: the words vector's error summary.Bedrock check, run locally
The coordinator from this branch with
--text-check bedrock --text-check-model us.anthropic.claude-haiku-5-5 --text-check-region us-west-2, words sent over/livefrom a dev box (round trip from send to receipt; one shared box, not a performance number):With
--text-check nonethe receipt readswords are turned off right now. With a model id that does not exist it readscouldn't check that word, try again, and the log hastext check failed error=Bedrock answered 400 Bad Request: The provided model identifier is invalid.All answers were well insideCHECK_TIMEOUT(5 s).