Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ Contributors:
* Diego
* Chris (ChrisJr404)
* Pieter Ouwerkerk (pouwerkerk)
* Paco Cartones (pacocartones)

Creator:
--------
Expand Down
5 changes: 5 additions & 0 deletions changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ Internal:
``Scenario: edit sql in file with external editor`` as an error. Raised to 10
seconds; passing runs are unaffected because pexpect returns as soon as the
expected text appears.
* Remove a stale ``@pytest.mark.xfail`` on
``test_simple_insert_single_table_schema_qualified``. It was marked for an old
``sqlparse`` that mislabeled schema-qualified ``INSERT``; the test now passes
across the supported ``sqlparse`` range (0.3.0 to 0.6.x), so the marker only
hid a passing test (an unreported XPASS, since ``xfail_strict`` is not set).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this. The changelog is for users of pgcli, who are unlikely to feel concerned and interested by this change.

Also, I am not sure that this warrants an addition in AUTHORS. Unless you really want your name there, of course...


Bug fixes:
----------
Expand Down
1 change: 0 additions & 1 deletion tests/parseutils/test_parseutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ def test_simple_insert_single_table():
assert tables == ((None, "abc", "abc", False),)


@pytest.mark.xfail
def test_simple_insert_single_table_schema_qualified():
tables = extract_tables('insert into abc.def (id, name) values (1, "def")')
assert tables == (("abc", "def", None, False),)
Expand Down
Loading