Remove stale xfail on schema-qualified INSERT parseutils test - #1625
Open
pacocartones wants to merge 1 commit into
Open
Remove stale xfail on schema-qualified INSERT parseutils test#1625pacocartones wants to merge 1 commit into
pacocartones wants to merge 1 commit into
Conversation
test_simple_insert_single_table_schema_qualified was marked xfail for an old sqlparse that mislabeled schema-qualified INSERT statements. That is long fixed: the test passes across the supported range (sqlparse 0.3.0 through 0.6.x), so the marker only produced an XPASS. Because xfail_strict is not set, that XPASS was silent and the assertion never gated anything. Drop the decorator so the test guards extract_tables again.
dbaty
reviewed
Aug 28, 2026
| ``test_simple_insert_single_table_schema_qualified``. It was marked for an old | ||
| ``sqlparse`` that mislabeled schema-qualified ``INSERT``; the test now passes | ||
| across the supported ``sqlparse`` range (0.3.0 to 0.6.x), so the marker only | ||
| hid a passing test (an unreported XPASS, since ``xfail_strict`` is not set). |
Member
There was a problem hiding this comment.
Please remove this. The changelog is for users of pgcli, who are unlikely to feel concerned and interested by this change.
Also, I am not sure that this warrants an addition in AUTHORS. Unless you really want your name there, of course...
Member
|
Also, there is another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_simple_insert_single_table_schema_qualifiedintests/parseutils/test_parseutils.pywas marked@pytest.mark.xfailback when anolder
sqlparsemislabeled schema-qualifiedINSERTstatements. That has longbeen fixed. The test now passes across the whole supported range
(
sqlparse >=0.3.0,<0.7— I checked 0.3.0 and 0.6.0), so the marker only everproduced an XPASS.
Since
xfail_strictisn't set, that XPASS was silent, which means the assertionwasn't actually guarding
extract_tablesanymore. This just drops the decoratorso the test does its job again. No production code changes.
Verified locally: the file passes repeatedly on both sqlparse 0.3.0 and 0.6.0,
and
ruff format/ruff checkare clean.Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).