Skip to content

merge-pr: go ahead without Greptile when it created no review for the head #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ualtinok merged 1 commit into from
Oct 27, 2026
Merged

merge-pr: go ahead without Greptile when it created no review for the head #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions benchmarks/aft-search/slice-descriptors/land-merge-without-absent-greptile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"fixtures": [
"harness-goldens"
],
"kind": "harness",
"slice_class": "non_ranking",
"targeted_mechanism": "none"
}
12 changes: 11 additions & 1 deletion scripts/merge-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,15 @@ disarm_auto_merge() {
}

wait_for_greptile_review() {
local head_sha="$1" timeout poll started now review_status review_conclusion review_result
local head_sha="$1" timeout poll absent_grace started now review_status review_conclusion review_result
timeout="${AFT_MERGE_PR_GREPTILE_TIMEOUT_SECONDS:-1200}"
poll="${AFT_MERGE_PR_GREPTILE_POLL_SECONDS:-15}"
# Greptile creates its check run (queued) within seconds of a push. When it
# has created nothing for a head after this long, it is not reviewing this
# repository (an outage or a spent allowance), and the PR goes ahead without
# it. A review that exists is still waited for, and a failed one still
# refuses. Set it to 0 to require a Greptile review again.
absent_grace="${AFT_MERGE_PR_GREPTILE_ABSENT_GRACE_SECONDS:-180}"
started=$(date -u +%s)
while :; do
review_result=$("$OPERATOR_GH" api "repos/$OWNER_REPO/commits/$head_sha/check-runs?per_page=100" \
Expand All @@ -108,6 +114,10 @@ wait_for_greptile_review() {
esac
fi
now=$(date -u +%s)
if [[ -z "$review_status" ]] && (( absent_grace > 0 && now - started >= absent_grace )); then
echo "merge-pr: WARNING: Greptile created no review for head $head_sha within ${absent_grace}s; submitting without it" >&2
return 0
fi
if (( now - started >= timeout )); then
hard_refuse "Greptile Review did not complete for head $head_sha within ${timeout}s; refusing blind submission"
fi
Expand Down
Loading