Skip to content

fix(bot): reject empty keywords in arrays #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leifermendez merged 1 commit into from
Oct 26, 2026
Merged

fix(bot): reject empty keywords in arrays #1275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/bot/__tests__/units/methods.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,4 +161,9 @@ test('addKeyword debe rechazar array vacío', () => {
assert.throws(() => addKeyword([] as any), /empty/i)
})

test('addKeyword debe rechazar strings vacíos dentro del array', () => {
assert.throws(() => addKeyword(['']), /empty/i)
assert.throws(() => addKeyword(['hola', '']), /empty/i)
})

test.run()
6 changes: 2 additions & 4 deletions packages/bot/src/io/methods/addKeyword.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ const addKeyword = <P = any, B = any>(
throw new Error('DEBE_SER_STRING_ARRAY_REGEX')
}

// Un keyword vacío nunca puede matchear nada: casi siempre es un error de
// configuración (p. ej. una env var sin definir). Fallamos rápido en lugar
// de registrar un flow muerto que nunca se dispara.
if (keyword.length === 0) {
// Empty entries become match-all regular expressions in FlowClass.
if (keyword.length === 0 || (Array.isArray(keyword) && keyword.some((item) => item.length === 0))) {
throw new Error('KEYWORD_CANNOT_BE_EMPTY')
}

Expand Down