Repository navigation
fix(bot): reject empty keywords in arrays - #1275
Merged
leifermendez merged 1 commit intoOct 26, 2026
Merged
leifermendez merged 1 commit into
leifermendez merged 1 commit into
Conversation
leifermendez
approved these changes
Oct 26, 2026
leifermendez
left a comment
Member
There was a problem hiding this comment.
Aprobado. La validaci贸n evita que una entrada vac铆a en el array convierta el flujo en un match accidental y conserva el error KEYWORD_CANNOT_BE_EMPTY. Verificaci贸n del commit revisado: 16/16 tests de m茅todos y 209/209 tests del paquete aprobados (1 omitido por la suite), m谩s comparaci贸n base/head del matching y compatibilidad de entradas v谩lidas. El rechazo de configuraciones que depend铆an de keywords vac铆as es intencional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Que tipo de Pull Request es?
Descripci贸n
Refs #1255 (the remaining empty-array-entry case).
The existing guard rejects
addKeyword('')andaddKeyword([]), but an empty string inside a non-empty array still passes.FlowClassturns that entry into an empty regular expression, allowing unrelated incoming messages to match the flow.Changes
KEYWORD_CANNOT_BE_EMPTYerror.['']and['hola', ''].Verification
pnpm test: all 29 monorepo test projects passed.pnpm --filter @builderbot/bot build: passed.