Repository navigation
Reproduce corrected OWC piston path for full parity gate - #627
Merged
Merged
Conversation
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Adds a full-duration physical comparison for issue #622. The test independently advances public Python OWC motion from the pinned HDF5 and PM wave phases, then compares body and piston motion, PTO force and power, air pressure and flow, and integrated work with a corrected MATLAB case.
The corrected case is derived from the original pinned Applications
OWC/OrificeModel: a repository-local MATLAB script adds the existing piston reaction to the flexible GBM state-equation input on a disposable model copy. A refined solver clock of0.00015625s retains0.005s output and force-sampling clocks. The source fixture contains 26,001 output samples; work and maximum Mach use all 832,001 internal orifice samples. The follow-up Python-repository workflow in #641 regenerates this source from the pinned original case and gates fresh MATLAB output against independent Python.Measured results
The test also reconstructs MATLAB orifice outputs from its separately logged piston speed and the documented air law. All declared limits pass. The repository-local 130 s source run reproduces the archived arrays within
3.96e-11and passes the fresh-source Python gate.Parity status
This is a derived-model comparison. The unchanged published Simulink input omits piston force from flexible state integration, so
OWC/OrificeModelretainsqualified_motionstatus and the strict badge count does not change.