Repository navigation
Conversation
This was referenced Oct 22, 2026
cmccomb
marked this pull request as draft
October 22, 2026 23:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include the orifice piston force in the generalized-body-mode (GBM) state input of
OWC/OrificeModel/OWC_GBM.slx. Previously, the force reached the reported flexible-body acceleration while the state-space integration received wave excitation alone. The new sum sends excitation plus piston force toProduct4/2; the existing flexible stiffness and damping remain in the state-space block.Set
simu.dt = 0.00015625s in the published input, withsimu.dtOut = 0.005s. ExplicitcicDt,nonlinearDt, andmorisonDtvalues retain their original 0.005 s force-sampling clocks. WEC-Sim initialization overwrites the model's saved MaxStep withsimu.dt, so changing the.slxsetting alone was insufficient. A full audit at the old 0.005 s step found 1.687 m maximum surge and 1.62% PTO-work differences against a refined solver run, with identical waves and no Mach-limit events. The published-input run is being checked through cmudrc/wec-sim-python#627.The model was edited and saved in MATLAB R2023b, matching the original model release. The reproducible signal-edit script asserts the original wiring. The model in this PR has SHA-256
5f9f1da3bf73e85b52224a3ff483991c3ec60774b92856e3c45cda4347927b59; its alternate configuration remains at the original settings, and the active one changes only MaxStep.Validation
d53d4d4c9eda2581f04204f5d394a6ef84bb099e, with WEC-Sim core0753b2e47f2457c078751dcfe5d251d1767b80aband pinned cleaned Test 17a hydrodynamics.1e-9, and passed independent Python motion and air-system gates in cmudrc/wec-sim-python#627. Maximum Python/source surge difference was 2.246 mm; signed PTO work differed by 0.0717%; peak internal-air Mach was 0.155.3.96e-11; source work is 864.422 J and peak Mach is 0.155. The final source workflow run also passes the strict1e-9archive assertion and fresh-source Python gate.Related to cmudrc/wec-sim-python#622.