Skip to content

merge queue: checking #2408 on master (a037246), stacked on #2413 - #2418

Closed
mergify[bot] wants to merge 5 commits into
masterfrom
mergify/merge-queue/126ea808ec
Closed

merge queue: checking #2408 on master (a037246), stacked on #2413#2418
mergify[bot] wants to merge 5 commits into
masterfrom
mergify/merge-queue/126ea808ec

Conversation

@mergify

@mergify mergify Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch minor-cantal-552olw of the changes queue, to test #2408 before it merges into master. Pushing to this branch or closing this pull request removes #2408 from the queue.

What this draft tests

Mergify checks that #2408 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:

  1. master at a037246
  2. the pull request queued ahead of this batch, listed below, which brings the tip to 834cf7b
  3. #2408, the pull request of this batch

The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the changes queue in the dashboard

What happens next

  • Once the pull requests ahead have merged, Mergify merges #2408 into master and closes this draft.
  • If a pull request ahead fails or leaves the queue without merging, this batch is requeued and checked again on a new draft: these checks assumed it would merge.

Tip

A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the pull request ahead, so a failure here can come from it as much as from #2408. See only this batch's changes.

Queued ahead of this batch

This pull request entered the queue before this batch and is not part of it.

Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: 834cf7b9f8835890a9e35a2e28ae1b7f53f9f243
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 2408
    scopes:
      - core
scopes:
  - core
...
1 scope
  • core
Required conditions of queue rule changes for merge
  • check-success = Conventional Commit title
  • check-success = Queue validation
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Lint & Format
    • check-neutral = @github-actions/Lint & Format
    • check-skipped = @github-actions/Lint & Format
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Rust Test & NAPI Build
    • check-neutral = @github-actions/Rust Test & NAPI Build
    • check-skipped = @github-actions/Rust Test & NAPI Build
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/JS Test (Ubuntu)
    • check-neutral = @github-actions/JS Test (Ubuntu)
    • check-skipped = @github-actions/JS Test (Ubuntu)
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Conventional Commit title
    • check-neutral = @github-actions/Conventional Commit title
    • check-skipped = @github-actions/Conventional Commit title
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Queue validation
    • check-neutral = @github-actions/Queue validation
    • check-skipped = @github-actions/Queue validation
Required conditions to stay in the queue

tignear and others added 5 commits October 28, 2026 16:42
@tignear
feat(sv)!: execute clocked Boolean concurrent assertions
7db845a 
Explicitly clocked Boolean `assert property`, `assume property`, and `cover property` now execute in module and generate scopes. Predicates use Preponed samples, `disable iff` reads the live value after NBA, and all Observed decisions finish before Reactive actions execute. Actions read live values.

This is the initial single-cycle subset. Named properties/sequences, temporal operators (`##`, implication, repetition), default clocks, procedural concurrent assertions, and timed or nonblocking action statements remain unsupported and diagnosed. It does not implement full SVA.

The runtime preserves pending Observed work across stop/resume and portable state files, validates restored region membership, and supports native images. Native image format advances to 52; state files with pending Observed work use version 4, while older versions remain readable.

Validation on master d8a6d72: full SV 6,233 passed (20 existing ignored), affected units 1,130 passed, new API 5 passed, state/checkpoint/fork regressions 90 passed, retained-report checks 4 passed, Clippy, and JS 435 passed. Before synchronization, the official unmodified sv-tests runner: 52 chapter-16 verdicts checked, six fail-to-pass improvements and no regressions. Only those six expected verdicts change.

External checks retain strict assertions and standalone Top/Wrapped evidence. Verilator passes two cases, disagrees on two scheduling cases, and cannot exercise the four-state case. Icarus rejects the five concurrent assertion cases. Installed xezim passes four and disagrees on Observed/Reactive ordering for one; its exact binary provenance is retained. The pinned xezim build was unavailable due to its dependency-lock mismatch, so these results do not claim current-pin coverage.

Independent change based on master; no dependency on another open PR.

Change-Id: I42c683a7842ade2dc5320c44f23d5dca3952084b
@renovate
chore(deps): update rust toolchain to 19ecdd0
c6f43ed
@tignear
test(sv): retain generated sampled assertion successes
045d4d5 
The complete official sv-tests CI corpus also passes the generated 20.13 sampled-function case in both state modes. The chapter-16 focused preflight did not include this generated group. Both official simulation logs report rc=0 and PASS; all 3300 retained verdicts match CI run 40652055752 after updating these two rows.

Change-Id: I82b9bda60aba4389c372970ebe8c6abc862e7d7e
@mergify @mergify-commit-signer
Merge of #2413
834cf7b
@mergify @mergify-commit-signer
Merge of #2408
e6526f4
@mergify mergify Bot mentioned this pull request Oct 28, 2026
Merged
@mergify mergify Bot closed this Oct 28, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/126ea808ec branch October 28, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tignear