Repository navigation
ci: preserve shared Rust caches and avoid unnecessary product builds #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Warm Rust dependency cache | ||
|
|
||
| # PR merge-ref caches cannot be reused by other PRs. Populate the default | ||
| # branch cache once per toolchain/dependency key, without running tests twice. | ||
| on: | ||
| push: | ||
| branches: [master] | ||
| paths: | ||
| - "**/Cargo.toml" | ||
| - "**/Cargo.lock" | ||
| - "rust-toolchain.toml" | ||
| - ".cargo/**" | ||
| - ".github/actions/setup-rust/**" | ||
| - ".github/workflows/rust-cache.yml" | ||
| - ".github/workflows/ci.yml" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: rust-dependency-cache-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| env: | ||
| CARGO_INCREMENTAL: "0" | ||
|
|
||
| jobs: | ||
| # Same job ID, runner, toolchain and environment as CI's Rust Tests cache. | ||
| rust-tests: | ||
| if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch) | ||
| name: Populate Rust Tests dependency cache | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 45 | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| with: | ||
| submodules: recursive | ||
| - uses: ./.github/actions/setup-rust | ||
| - uses: Swatinem/rust-cache@v2 | ||
| id: cache | ||
| - name: Install cargo-nextest | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cargo-nextest@0.9.144 | ||
| - name: Build test targets to populate dependencies | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| run: >- | ||
| cargo nextest list --locked --workspace --message-format json | ||
| --features celox/systemverilog,celox-test-suite/verilator,celox-test-suite/icarus | ||
| > /dev/null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a PR changes only
.github/workflows/rust-cache.yml, this condition does not setscripts, and the later generic.github/workflows/branch treats the file as neutral. Consequently the lint job skipsnode --test scripts/*.test.mjs, so the newly added test that reads this workflow never checks the very edits it is meant to protect; a mismatch in the job ID, features, nextest version, or cache policy can therefore merge without validation. Include this workflow in the script-validation classification (or otherwise schedule its focused test).AGENTS.md reference: AGENTS.md:L14-L16
Useful? React with 👍 / 👎.