Skip to content

Files: device filter, screen search, usage in the sidebar - #1272

Merged
Zach Dunn (zachdunn) merged 2 commits into
mainfrom
claude/project-thread-1xds70
Oct 22, 2026
Merged

Zach Dunn (zachdunn) merged 2 commits into
mainfrom
claude/project-thread-1xds70

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Requested by Zach · project thread

What changed

Usage moves to the sidebar. The usage meters leave the right rail (Files and Billing) and sit at the bottom of the left sidebar on every workspace tab. Collapsed, it shows one line: the fullest meter. Expanding shows every meter and the object count. The open/closed choice is remembered per browser. It hides when the sidebar collapses to icons.

Device filter. The Type select gains a Device group: Mobile, Desktop, Tablet. It's backed by the classifier's ai.surface label, so files that were never classified don't match. The API takes ?surface= on /pulls, /repos, scope files and files/by-path (an EXISTS on the PK). Drill-ins filter on meta.ai.surface. Picking a device clears the file kind and the other way round, so the bar keeps one control.

Search covers screen. By page used to list only files with a path, so mobile screenshots tagged with --screen never showed up. A file with a screen and no path now groups under its screen name (by: "screen", shown with a small "screen" tag). It's searchable and suggested, and drills in through ?screen=. A file that has both still groups by path.

Error boundaries. Every island already had one. IslandErrorBoundary now takes a fallback, and the sidebar usage footer has its own quiet boundary, so a crash there can't take the navigation down with it.

Query cleanup.

  • The PR view's repo select called /repos, which loads thumbnails and open-PR counts for 20 repos just to read their names, and the page waited on it during SSR. It now asks for names only (thumbnails=0, 50 per page).
  • files/by-path runs its metadata, timestamp and storage-config reads in parallel instead of one after another.

Testing

  • pnpm typecheck, pnpm check, pnpm test:api (3506 pass), web vitest (1347 pass).
  • New tests: surface filter on /pulls and scope files, /repos?thumbnails=0, invalid_surface, screen grouping and the surface filter in groupObjectsByPath, URL round-trip for surface and screen, and screen/path suggestions.
  • Checked on a local stack with mobile, desktop and tablet fixtures (screenshots in the comment).

Generated by Claude Code

- Type select gains a Device group (Mobile, Desktop, Tablet) backed by the
  classifier's `ai.surface` label. `?surface=` on /pulls, /repos, scope
  files, and files/by-path; drill-ins filter on `meta.ai.surface`.
- By page now groups files that have a `screen` and no `path` under their
  screen name (`by: "screen"`), so the page search finds mobile app
  screens. Drill-ins use `?screen=`.
- Workspace usage moves from the right rail to a collapsible footer at the
  bottom of the sidebar, on every workspace tab, with its own quiet error
  boundary so a crash there never takes the nav down.
- The PR view's repo select asks /repos for names only (`thumbnails=0`)
  instead of loading thumbnails and open-PR counts for every repo.
- files/by-path runs its metadata, timestamp, and storage-config reads in
  parallel.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FsGRzxzuHgaKiSjXwGmWL6
@changeset-bot

changeset-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6b25002

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zachdunn Zach Dunn (zachdunn) self-assigned this Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 2
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed): 1
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c64a1cca-88aa-437a-987b-3ceb16519fad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@uploads-sh

uploads-sh Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

files-device-mobile.png
/account/workspaces/:name/files · after

files-screen-drill.png
/account/workspaces/:name/files · after

files-search-screen.png
/account/workspaces/:name/files · after

sidebar-usage-open.png
/account/workspaces/:name/files · after

AI notes · nothing to flag
  • ✅ After screens look ready
  • ➖ Before and after not compared
    • Needs a file marked as before and one marked as after.

View on uploads.sh

4 files · add media: uploads put <file> --pr 1272 · docs

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FsGRzxzuHgaKiSjXwGmWL6
@zachdunn
Zach Dunn (zachdunn) merged commit 2b13fdd into main Oct 22, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/project-thread-1xds70 branch October 22, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants