Skip to content

Files: one Filters menu with active-filter chips - #1273

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/project-thread-1xds70
Oct 22, 2026
Merged

Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/project-thread-1xds70

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Follow-up to #1272 (option B from the filter bar mockups).

Every Files view now uses the same bar:

  • By page: a full-width "Search paths and screens" box, then one Filters button with a count, then a Grouped / Newest first icon toggle. The popover holds Type, Device, Project and Merged only.
  • By pull request: Filters (Type, Device, Repo, State).
  • By repo and the repo / PR scope pages: Filters (Type, Device). The PR page keeps its "Group by page" toggle beside the button.
  • Active filters show as removable chips under the bar, with a Clear link when there are two or more.
  • Type and Device are now separate and combine (for example, Mobile + Videos). The API already ANDed both. Empty-state copy reads "mobile videos".
  • On phones, the shortcut hint and the "Filters" word hide, so the search box keeps its room.

FilterControls.tsx now holds FilterBar, FilterSection, TypeSections + typeChips, ScopeSelect, PrStateSection and MergedOnlyCheckbox. The old TypeSelect / RepoSelect / PrStateSelect are gone. No URL or API changes.

Checked locally on the dev stack: the popover opens, removing the Mobile chip drops surface= from the URL, and the layout holds at 390 px. astro check is clean and the web tests pass (1347).


Generated by Claude Code

The filter bar is now search, one Filters button with a count, and a
Grouped / Newest first icon toggle. Type, Device, Project or Repo, State
and Merged only live in the popover; active ones show as removable chips
under the bar. Type and Device now combine.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FsGRzxzuHgaKiSjXwGmWL6
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: af16879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 2
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed): 1
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 502457cb-b634-4180-aabe-ef15e916fe0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@uploads-sh

uploads-sh Bot commented Oct 22, 2026

Copy link
Copy Markdown

files-filters-open.png
/account/workspaces/:name/files · after

files-filters-phone.png
/account/workspaces/:name/files · after

AI notes · nothing to flag
  • ✅ After screens look ready
  • ➖ Before and after not compared
    • Needs a file marked as before and one marked as after.

View on uploads.sh

2 files · add media: uploads put <file> --pr 1273 · docs

@zachdunn
Zach Dunn (zachdunn) merged commit afeadb4 into main Oct 22, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/project-thread-1xds70 branch October 22, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants