Repository navigation
feat(anatomy): margin notes and a tonal flat view instead of numbered keys - #41
Merged
Zach Dunn (zachdunn) merged 3 commits intoOct 16, 2026
Merged
Conversation
… keys
The flat and screenshot views put each key's text in the margin, joined to
its part by a bracket ("span": true) or a dot. Below about 560px they fall
back to small numbers and the legend. "notes": "keys" keeps the old
hotspots; iso always uses them. The flat view takes the iso tones with an
offset shadow, and the site's digest card is drawn flat instead of iso.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
4 files · View all on uploads.sh → Maintained by uploads.sh · add media: |
…margin notes The weekly-digests and walkthrough-videos posts get the new figures and the template's current CSS, with captions to match. The walkthrough frame brackets its shot and caption keys so no leader crosses the caption chip. The README hero, digest and walkthrough images are recaptured from them.
…previews The examples page and docs/components.md show the flat card with margin notes instead of the iso apart picture, which is removed. The link-preview figure is fitted to its panel so the margin notes aren't clipped, and the previews are rebuilt.
Zach Dunn (zachdunn)
added this pull request to stack #43
October 16, 2026 02:38
Zach Dunn (zachdunn)
deleted the
claude/diagram-style-refinement-eb073e
branch
October 16, 2026 02:40
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What this changes
anatomyflat and screenshot views now put each key's text in the margin beside the figure, joined to its part by a hairline: a bracket for a key with"span": true, a dot for the rest. Notes keep the order of their anchors and push down so they never overlap, and a margin appears only on a side that has notes."notes": "keys"keeps the old numbered hotspots. Iso always uses them.flatinstead ofiso, and its captions are updated. The iso pictures of each output type are unchanged.lint.mjscounts margin notes as hotspots.inline-assets.mjsand the gallery handle SVG<image href>, which the screenshot view now uses.references/visuals.md,docs/components.md, gallery notes.Why
The iso view of a screenshot spent ink on thickness the object doesn't have, and it foreshortened the tiles whose size is the point. Numbered discs also made the reader look down to the legend and back for every key. Margin notes label things where they are, so there's no legend to cross-reference. Iso stays for pictures where how the parts stack is the point.
We also explored a halftone finish. It's parked: it works for drawn interfaces but not for photographic captures, and it needs a limit on how much of a figure is textured before it's viable.
Checks
UnreleasedinCHANGELOG.md.node --test dev/test/*.test.mjspasses on Node 22 (121 tests).