Skip to content

test: fix flaky memory_bytes check in 05_stats.t #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuelnaranjo merged 1 commit into from
Oct 22, 2026
Merged

test: fix flaky memory_bytes check in 05_stats.t #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion t/05_stats.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use strict;
use warnings;

use Data::Dumper;
use Scalar::Util qw(looks_like_number);
use Test::More;

my $CLASS = 'JavaScript::V8::XS';
Expand Down Expand Up @@ -36,7 +37,13 @@ sub test_stats {
my $data = $stats->{$category};
foreach my $name (qw/ memory_bytes elapsed_us /) {
ok(exists $data->{$name}, "name $name exists in stats for $category");
ok($data->{$name} >= 0, "name $name has a valid value in stats for $category");
# memory_bytes is a delta of process memory and can
# be negative if V8 releases memory (e.g. on GC)
if ($name eq 'memory_bytes') {
ok(looks_like_number($data->{$name}), "name $name has a valid value in stats for $category");
} else {
ok($data->{$name} >= 0, "name $name has a valid value in stats for $category");
}
}
}
}
Expand Down
Loading