Repository navigation
test: fix flaky memory_bytes check in 05_stats.t - #3
Merged
Merged
Conversation
memory_bytes is the change in process memory size (VmSize from /proc/self/statm) across an eval. It is negative whenever V8 unmaps memory during the eval, so asserting memory_bytes >= 0 failed in roughly 5-25% of runs. Check that it is a number instead; elapsed_us keeps the >= 0 check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t/05_stats.tfailed intermittently (2/20 runs on perl 5.36, 5/20 on perl 5.42) on the assertionmemory_bytes >= 0.memory_bytesis the change in process memory size (VmSize from/proc/self/statm) across an eval. It is legitimately negative whenever V8 releasesmemory during the eval; failing runs showed values such as
-490668, with noNaN/undefvalues. The test now checks thatmemory_bytesis a number;elapsed_uskeeps the>= 0check.Testing
05_stats.twas the only failure.05_stats.t× 50 runs on each perl, 0 failures.Follow-up
V8Context.cc:47initializespagesize_byteswithtotal_memory_pages()(the page count) instead of the system page size, somemory_bytesis scaledby the wrong factor. Left for a separate change since it alters the values
get_stats()reports.🤖 Generated with Claude Code