Skip to content

feat(explore): label name-only calls in the Relationships list - #455

Merged
bompus merged 1 commit into
fork/consolidatedfrom
feat/relationships-name-guess
Oct 11, 2026
Merged

bompus merged 1 commit into
fork/consolidatedfrom
feat/relationships-name-guess

Conversation

@bompus

@bompus bompus commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

The survey's step 2 asked to persist a resolution origin and confidence on every edge and show them in explore. Most of that exists: the resolver stores resolvedBy and confidence in each edge's metadata (78,176 of 123,086 edges in this repository's index), graph/edge-trust.ts flags name-only hops, and codegraph_node's trail and explore's Flow print [name match, unverified].

The one place that still printed a bare arrow was explore's Relationships list (repositories of 500 files or more). This labels it the same way, using the same isNameGuess rule.

Checks. A new test in edge-trust.test.ts (520-file project): - run → helper [name match, unverified] and - run → proven; it fails without the change (expected [ '- run → helper', '- run → proven' ] to include …). Full suite: 688 files, 8773 tests passed, 39 skipped. TypeScript only; no kernel change.

Not done. No new strategy names or a confidence column on edges; the existing metadata already carries both.


Summary by cubic

Labels name-only call edges in explore's Relationships list with [name match, unverified], matching what codegraph_node's trail and explore's Flow already show. The Relationships list (rendered for repositories of 500 files or more) previously printed a bare arrow for edges the resolver could only bind by callee name; it now flags them the same way, so every place explore draws a call edge carries the same warning.

Written for commit 3959f1e. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Bug Fixes
    • In repositories with 500 or more files, Explore’s Relationships list now labels calls matched by name alone as [name match, unverified]. Verified relationships retain their existing display.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 48e19975-548b-4bf9-ad67-5a73405bd91e

📥 Commits

Reviewing files that changed from the base of the PR and between 3a32a33 and 3959f1e.


📒 Files selected for processing (3)
  • CHANGELOG.md
  • __tests__/edge-trust.test.ts
  • src/mcp/tools.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.



📝 Walkthrough

Walkthrough

Explore’s Relationships list now marks name-guess edges as [name match, unverified]. An integration test checks the label in a repository with 520 files.

Changes

Explore relationship labels

Layer / File(s) Summary
Mark name-guess edges
src/mcp/tools.ts, __tests__/edge-trust.test.ts, CHANGELOG.md
Relationship entries retain whether an edge is a name-based guess and add [name match, unverified] to guessed edges. The integration test checks guessed and imported edges in a 520-file repository. The changelog records the fix for repositories with at least 500 files.

Priority: ⬇️ Low

Merge Risk | ⚪ Minimal · up to 3959f

Merge Risk: ⚪ Minimal · up to 3959f

Explore's Relationships list now marks name-matched calls as unverified in repositories with 500 or more files. The change is small and display-only, and no merge-blocking risk was identified.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 3959f

The change adds an informational warning to name-guessed relationships without changing graph resolution, permissions, or tool capabilities. No material security risk was identified in the change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • observed — The routed write declaration is local to test setup and writes fixed fixtures into a temporary directory. It is not exposed through production tool dispatch.

Trust Boundaries and Controls

  • observed — The changed rendering remains within the existing read-oriented Explore path. It introduces no new caller, permission, privileged operation, or enforcement bypass.

Pre-merge checks | Passed 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: labeling name-only calls in Explore’s Relationships list.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Suppressions Explained Passed The pull request adds no lint, type-check, compiler, or configuration suppression directive. The changed lines add relationship labeling and a test; the added /* ignore */ is an ordinary catch comme…
User-Visible Changes Documented Passed PASS. The diff changes only the rendered labels in the existing codegraph_explore Relationships list, plus a test and CHANGELOG.md. It does not add, remove, or rename a CLI command or flag, MCP to…

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@bompus
bompus merged commit d182e91 into fork/consolidated Oct 11, 2026
5 checks passed
@bompus
bompus deleted the feat/relationships-name-guess branch October 11, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant