Repository navigation
Decode Opus files with libopus - #4
Merged
Merged
Conversation
Symphonia has no Opus decoder, so .opus files (what yt-dlp and many web sources hand out) imported into the library but could never be analysed or played. Register symphonia-adapter-libopus alongside Symphonia's own decoders in the one shared decode path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dropping
.opusfiles into the library imported them (tags are read with lofty), but Symphonia has no Opus decoder, so analysis and playback failed for every one of them. No BPM, key, waveform or audio.Fix
crates/audio/src/decode.rs: a codec registry with Symphonia's enabled decoders plussymphonia_adapter_libopus::OpusDecoder, used bydecode_native. Every caller (analysis, playback, stems, Live mode) goes through this function.opusic-sys, so no system library is needed. Added toATTRIBUTION.md(BSD-3-Clause).Testing
opus_has_a_decoder.analyzeexample on a real 262 s Ogg Opus track: decodes in 1.9 s; 124 BPM, C#m, sections found.cargo clippy --workspace --all-targets -- -D warningspasses.🤖 Generated with Claude Code