Repository navigation
Studio: drop files onto the timeline, new Add tracks dialog - #5
Merged
Merged
Conversation
Symphonia has no Opus decoder, so .opus files (what yt-dlp and many web sources hand out) imported into the library but could never be analysed or played. Register symphonia-adapter-libopus alongside Symphonia's own decoders in the one shared decode path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Files dropped from Finder onto the studio were only imported into the library, so nothing appeared in the mix. They now join the end of the mix, in drop order, once each is imported and analysed (mix points need the grid and cues). Sample lanes still take drops as samples. "+ Add tracks" opens a dialog instead of a dropdown: search, sortable columns (BPM, key, energy, length), a fit column and filter against the mix's last track (harmonic key, tempo within 6 %), a preview from the track's first drop with a clickable waveform, and multi-select. devctl gains `drop <path>`, `add-tracks [query]`, `picker-preview <query>` and `mute` for automated checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #4 (Opus decoding), which is not merged yet, so this branch contains that commit too. Merging this PR lands both; #4 can then be closed.
Drop files onto the studio
Files dragged from Finder onto the studio timeline were only imported into the library; nothing appeared in the mix. Now they are imported as before and join the end of the mix, in drop order, as soon as each has an analysis (mix points need the beat grid and cues). Once background jobs are idle, tracks whose analysis failed still join, and files that could not be imported are skipped. Sample lanes still take drops as samples; drops in the library only import.
Add tracks dialog
+ Add tracksopens a dialog in the app's look (track_picker.rs) instead of a dropdown:Developer control
devctlgainsdrop <path>(injects a Finder-style drop),add-tracks [query],picker-preview <query>andmute.Testing
CLUBCRAFT_HOMEin a temp folder, master volume at 0):dropof a folder onto the studio added both tracks to the mix in order with a stem blend; the dialog opened, previews played from the drop with a moving playhead, and switching previews worked.cargo clippy --workspace --all-targets -- -D warningspasses;cargo test -p clubcraft -p clubcraft-audiopasses.🤖 Generated with Claude Code