Repository navigation
Add kernel32.lib and ntdll.lib to MSVC stdlib linkflags - #4376
Open
TrapsterDK wants to merge 1 commit into
Open
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
Fixes bazelbuild#4375 Assisted-by: Claude
This was referenced Nov 3, 2026
Closed
TrapsterDK
added a commit
to devhusdk/rules_dx
that referenced
this pull request
Nov 4, 2026
) (#6629) Name bazelbuild/rules_rust#4376 in the rules_rust row so the patch is tied to the upstream PR. Whoever bumps rules_rust drops the patch once a BCR release carries that PR. Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4375
Adds
kernel32.libandntdll.libto the windows-msvc stdlib link flags. The gnu entries already list-lntdll. The existingwindows_stdlibunit tests are updated to expect the new flags and pass.Assisted-by: Claude
Assisted by Claude.