Repository navigation
patches: link the rules_rust MSVC stdlib patch to upstream (closes #5169) - #6629
Merged
Merged
Conversation
) Name bazelbuild/rules_rust#4376 in the rules_rust row so the patch is tied to the upstream PR. Whoever bumps rules_rust drops the patch once a BCR release carries that PR. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5169
The rules_rust MSVC stdlib link-flag patch is applied in-repo, and the upstream fix is open at bazelbuild/rules_rust#4376. This change names that PR in the
rules_rustrow ofpatches/README.md, the same way thewindows_supportrow links hermeticbuild/windows_support#19, so whoever bumps rules_rust can find the patch and see which upstream release retires it.Change: one cell in
patches/README.md. No code or lockfile change.Follow-up (not in this PR): once a BCR release of rules_rust carries #4376, delete
patches/rules_rust/msvc_stdlib_linkflags.patchand its references (MODULE.bazel, patches/rules_rust/BUILD.bazel, cli/adopt, cli/cli, and the README row).Checks: docs-only change.
tools/dx check --apply --affectedran but stopped atbazel build //:dxwith a pre-existingdx_crateslockfile digest mismatch on origin/main (Cargo.toml changed in 7a8789c without a repin). That is unrelated to this change; the diff touches onlypatches/README.md. Not run:tools/dx test(no test covers a README row), and no nested-Bazel or*_consumer_testtargets.🤖 Generated with Claude Code
Assisted by Claude.